On Tue, Mar 01, 2016 at 09:11:58PM +0000, Jose M Calhariz wrote:
> On 28/02/16 23:00, Mattia Rizzolo wrote:
> > On Wed, Feb 24, 2016 at 09:41:32PM +0000, Jose M Calhariz wrote:
> > * I just noticed sawfish.preinst removes /var/lib/sawfish that you are
> > creating in sawfish.dirs. ???
>
> I believe the directory /var/lib/sawfish is necessary. So cleaning
> sawfish.preinst
ok.
> > * in d/rules, is the ACLOCAL variable still needed? if not get rid of
> > it (test building without works)
>
> I tried to used automake instead of automake1.11 and worked for my
> machine (i386).
As a QA guy I like when I see old stuff being dropped from the archive,
so also avoiding hardcoding and fixing with automake1.11 will also help
remove automake1.11 when the time will come :)
> > after this, back to what lintian knows:
> >
> > * spelling-error-in-changelog unusuable unusable
>
> This is a misspell on the bug report title, so preserving the error and
> add an lintian-override for it.
brrrrrr, how ugly!
no, please revert that commit, retitle the bug report if you care and
fix the typo in the changelog. Also, there is no need at all that the
changelog entries for bug fix are the same of the bug reports...
Surely the most nice thing would be to retitle the bug report and fix
the changelog, adding a lintian override is just plain wrong here.
> I will work on the following tomorrow.
Thanks for showing the progress, appreciated as usual :)
> > * non-empty-dependency_libs-in-la-file + incorrect-libdir-in-la-file
> > these are caused just because of a typo in the target name of
> > override_dh_auto_install; I'll let you discover the typo and fix it.
> > * sawfish: maintainer-script-without-set-e (all the maintscripts)
> > * sawfish-lisp-source: script-not-executable usr/share/sawfish/lisp/sawfish/cfg/main.jl
> > there actually is an override, but the file is named wrongly and so
> > not picked up by dh_lintian. maybe you also want to add an override
> > for the sawfish-data one.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature