On Sat, Jan 09, 2016 at 05:06:16PM +0000, Jose M Calhariz wrote:
> One more iteraction.
oh, this is getting cooler and cooler :)
> On 07/01/16 14:31, Mattia Rizzolo wrote:
> > On Sun, Jan 03, 2016 at 08:23:34PM +0000, Jose M Calhariz wrote:
> >> On 03/01/16 13:21, Mattia Rizzolo wrote:
> >>> looks good to me. though I see there are files like
> >>> ./usr/lib/x86_64-linux-gnu/rep/rules.mk
> >>> that might be used by other packages.
> >>> but if that one is a makefile, why is it under /usr/lib ?
> >>>
> >>> I need to try a piuparts run, and see if everything is right.
> >>> Since there are only two r-deps once this package is more ready I'll try
> >>> to build them against this, to see if this multi-lib change affects
> >>> them.
> >> And I intended to adopt that two r-deps. What should make it easier.
> > Indeed, I'll probably double check this particular bit another day.
> >
> > Given that now librep16 is multiarch-able, you should add a
> > 'Multi-Arch: same' field in d/control for it.
>
> Done.
I'm going to try rebuilding the rdeps in the later today or tomrrow, and
I'll report back the results.
> I found the problem, Done.
woo :D
OK, if the r-deps check I'm going to do will succeed I think we're good
to upload. :)
just two more points:
I find d/chaneglog to be somewhat a lot verbose. I think it's too much
verbose and also contains nowadays outdated bits (e.g. "Replace sed by
something more easy to read for variable version on debian/rules" is
just useless, also considering that line now doesn't exist anymore at
all! that's just an example, I can see more). So if I were you I'd
try to re-read the whole changelog and make it more easy and useful.
The following lines are from check-all-the-things.
The first chunk shows there is a typo in debian/changelog, you might
want to fix it. Then I ask you to please forward all the rest
(typos or such, and outdated GPL-2+ text) upstream.
$ codespell --quiet-level=3
./Makedefs.in:105: dependancy ==> dependency
./ChangeLog:723: usefull ==> useful
./ChangeLog:870: usefull ==> useful
./configure:4647: nto ==> not | disable due to \n
./configure:7545: nto ==> not | disable due to \n
./configure:7695: nto ==> not | disable due to \n
./configure:8963: nto ==> not | disable due to \n
./configure:9998: nto ==> not | disable due to \n
./config.sub:1403: nto ==> not | disable due to \n
./NEWS:108: occured ==> occurred
./NEWS:376: usefull ==> useful
./aclocal.m4:106: occurence ==> occurrence
./debian/changelog:163: Miscelaneous ==> Miscellaneous
./intl/localealias.c:93: loosing ==> losing
./intl/dcgettext.c:174: loosing ==> losing
./intl/dcgettext.c:246: defintion ==> definition
./m4/libtool.m4:2727: nto ==> not | disable due to \n
./m4/libtool.m4:3317: nto ==> not | disable due to \n
./m4/libtool.m4:3961: nto ==> not | disable due to \n
./m4/libtool.m4:4117: nto ==> not | disable due to \n
./m4/libtool.m4:4283: nto ==> not | disable due to \n
./m4/libtool.m4:4434: nto ==> not | disable due to \n
./m4/libtool.m4:5382: nto ==> not | disable due to \n
./m4/libtool.m4:6581: nto ==> not | disable due to \n
./src/streams.c:618: upto ==> up to
./src/unix_main.c:452: Dont ==> Don't
./src/sdbm.c:81: seperate ==> separate
./src/README.sdbm:294: puting ==> putting
./man/repl.texi:3: enviroment ==> environment
./man/repl.texi:6: enviroment ==> environment
./man/lang.texi:790: upto ==> up to
./man/lang.texi:1414: sence ==> sense, since
./man/lang.texi:4828: contruction ==> construction
./man/lang.texi:4964: refered ==> referred
./man/lang.texi:5098: Ususally ==> Usually
./man/lang.texi:7300: upto ==> up to
./man/lang.texi:9367: seperated ==> separated
./man/lang.texi:9368: seperated ==> separated
./man/news.texi:83: positon ==> position
./man/news.texi:109: occured ==> occurred
./man/news.texi:379: usefull ==> useful
./lisp/rep/vm/assembler.jl:27: inbetween ==> between
$ licensecheck --check=. --recursive --copyright . | grep -F 'with incorrect FSF address'
./intl/loadmsgcat.c: GPL (v2 or later) (with incorrect FSF address)
./intl/l10nflist.c: GPL (v2 or later) (with incorrect FSF address)
./intl/explodename.c: GPL (v2 or later) (with incorrect FSF address)
./intl/textdomain.c: GPL (v2 or later) (with incorrect FSF address)
./intl/libgettext.h: GPL (v2 or later) (with incorrect FSF address)
./intl/localealias.c: GPL (v2 or later) (with incorrect FSF address)
./intl/gettext.h: GPL (v2 or later) (with incorrect FSF address)
./intl/gettextP.h: GPL (v2 or later) (with incorrect FSF address)
./intl/dgettext.c: GPL (v2 or later) (with incorrect FSF address)
./intl/cat-compat.c: GPL (v2 or later) (with incorrect FSF address)
./intl/po2tbl.sed.in: GPL (v2 or later) (with incorrect FSF address) GENERATED FILE
./intl/xopen-msg.sed: GPL (v2 or later) (with incorrect FSF address)
./intl/loadinfo.h: GPL (v2 or later) (with incorrect FSF address)
./intl/linux-msg.sed: GPL (v2 or later) (with incorrect FSF address)
./intl/dcgettext.c: GPL (v2 or later) (with incorrect FSF address)
./intl/bindtextdom.c: GPL (v2 or later) (with incorrect FSF address)
./intl/gettext.c: GPL (v2 or later) (with incorrect FSF address)
./intl/intl-compat.c: GPL (v2 or later) (with incorrect FSF address)
./intl/hash-string.h: GPL (v2 or later) (with incorrect FSF address)
./intl/Makefile.in: GPL (v2 or later) (with incorrect FSF address)
./intl/finddomain.c: GPL (v2 or later) (with incorrect FSF address)
./Makedefs.in: GPL (v2 or later) (with incorrect FSF address)
./src/lispmach.c: GPL (v2 or later) (with incorrect FSF address)
./src/origin.c: GPL (v2 or later) (with incorrect FSF address)
./src/weak-refs.c: GPL (v2 or later) (with incorrect FSF address)
./src/md5.c: GPL (v2 or later) (with incorrect FSF address)
./src/timers.c: GPL (v2 or later) (with incorrect FSF address)
./src/streams.c: GPL (v2 or later) (with incorrect FSF address)
./src/rep-xgettext.jl: *No copyright* GPL (v2 or later) (with incorrect FSF address)
./src/safemach.c: GPL (v2 or later) (with incorrect FSF address)
./src/readline.c: GPL (v2 or later) (with incorrect FSF address)
./src/datums.c: GPL (v2 or later) (with incorrect FSF address)
./src/realpath.c: LGPL (v2 or later) (with incorrect FSF address)
./src/find.c: GPL (v2 or later) (with incorrect FSF address)
./src/gh.c: GPL (v2 or later) (with incorrect FSF address)
./src/main.c: GPL (v2 or later) (with incorrect FSF address)
./src/ffi.c: GPL (v2 or later) (with incorrect FSF address)
./src/gettext.c: GPL (v2 or later) (with incorrect FSF address)
./src/unix_files.c: GPL (v2 or later) (with incorrect FSF address)
./src/tables.c: GPL (v2 or later) (with incorrect FSF address)
./src/macros.c: GPL (v2 or later) (with incorrect FSF address)
./src/symbols.c: GPL (v2 or later) (with incorrect FSF address)
./src/md5.h: GPL (v2 or later) (with incorrect FSF address)
./src/numbers.c: GPL (v2 or later) (with incorrect FSF address)
./src/rep-md5.c: GPL (v2 or later) (with incorrect FSF address)
./src/fluids.c: GPL (v2 or later) (with incorrect FSF address)
./src/rep-remote.c: GPL (v2 or later) (with incorrect FSF address)
./src/unix_main.c: GPL (v2 or later) (with incorrect FSF address)
./src/lispcmds.c: GPL (v2 or later) (with incorrect FSF address)
./src/tuples.c: GPL (v2 or later) (with incorrect FSF address)
./src/continuations.c: GPL (v2 or later) (with incorrect FSF address)
./src/files.c: GPL (v2 or later) (with incorrect FSF address)
./src/unix_processes.c: GPL (v2 or later) (with incorrect FSF address)
./src/debug-buffer.c: GPL (v2 or later) (with incorrect FSF address)
./src/lisp.c: GPL (v2 or later) (with incorrect FSF address)
./src/misc.c: GPL (v2 or later) (with incorrect FSF address)
./src/unix_dl.c: GPL (v2 or later) (with incorrect FSF address)
./src/record-profile.c: GPL (v2 or later) (with incorrect FSF address)
./src/structures.c: GPL (v2 or later) (with incorrect FSF address)
./src/message.c: GPL (v2 or later) (with incorrect FSF address)
./src/Makefile.in: GPL (v2 or later) (with incorrect FSF address)
./src/repdoc.c: GPL (v2 or later) (with incorrect FSF address)
./src/values.c: GPL (v2 or later) (with incorrect FSF address)
./src/utf8.c: GPL (v2 or later) (with incorrect FSF address)
./src/sockets.c: GPL (v2 or later) (with incorrect FSF address)
./man/Makefile.in: GPL (v2 or later) (with incorrect FSF address)
./lisp/rep/lang/backquote.jl: GPL (v2 or later) (with incorrect FSF address)
./lisp/Makefile.in: GPL (v2 or later) (with incorrect FSF address)
./Makefile.in: GPL (v2 or later) (with incorrect FSF address)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature