control: tag -1 +moreinfo
Hello Jörg,
On Thu, Dec 29, 2016 at 07:03:26PM +0100, Jörg Frings-Fürst wrote:
> first thanks for your first review.
No problem.
I've now taken a proper look at your copyright file. Some problems:
- the "FreeBSD" license has a standard shortname: BSD-2-clause
- did you make up the 'mixed', 'BSD-Revised' and 'permissive' license
shortnames? I suspect there are standard names -- try
http://codesearch.debian.net
- you can't claim 2017 copyright on debian/ since we will upload this
before 2017 begins :)
- if you run `licensecheck --copyright -r .` you will find many files
that are Copyright 2005 David Bullis. Maybe you should add this to
the "Files: *" stanza?
- Mikko Nissinen also holds copyright on app/i18n/stripmsg.c
- copyright years for getopt.*, uthash.h, gwin32.c, mswbitmap.c and
others are wrong -- why did you add '-2015' when the file was not
edited since the earlier year?
- copyright for app/tools/halibut/charset/macenc.c wrong
> > > Changes since the last upload:
> > >
> > > * New Maintainer (Closes: #849139):
> > > - debian/control: Add myself as maintainer.
> > > - debian/copyright: Add myself to debian/*.
> > > * New upstream release (Closes: #847843, #784423).
> >
> > In #847843, Mike Gabriel suggests team maintenance of xtrkcad. Have you
> > got in touch with him about maintaining xtrkcad together? Is he aware
> > of your ITA? #847843 is itself almost an ITA, and it was submitted only
> > very recently, so you should be sure that your upload doesn't treat on
> > Mike's toes.
> >
> My mistake. I have only skimmed through the text. I have ask Mike per
> mail and add him as Uploader.
Great. I suggest writing "(Closes: #847843)" next to the Uploader
change -- it is okay to 'close' a bug more than once in a single upload.
> > * Remove debian/source/options.
> >
> > Why?
>
> To use the default compression. Comment is added.
Okay.
> >
> > > * Remove debian/source.lintian-overrides.
> > > * Change debian/compat to 10 (no changes required).
> > > * debian/control:
> > > - Bump Standards-Version to 3.9.8 (no changes required).
> > > - Bump debhelper B-D minimum version to 10.
> > > - Add Vcs-* tags.
> > > - Change Priority from extra to optional.
> >
> > Just a reminder that you will have to submit a bug against
> > ftp.debian.org to have this actually take effect (post-adoption).
> >
>
> Because of the Priority change?
>
> The change was based on the comment at the old PTS[1].
Ah. You could mention this in your changelog, so I wouldn't ask the
question :) E.g.
- Change Priority from extra to optional.
To match current ftp-master override file.
> > > * debian/rules:
> > > - Enable hardening.
> > > * New debian/patches/0700-info_file.patch to add requested directory entry
> > > and INFO-DIR-SECTION.
> > > * Rewrite debian/watch to use the sf redirector.
> > > - Add files to exclude in debian/copyright.
> > > * Rewrite debian/copyright.
> >
> > Lintian tags you can easily fix:
> >
> > I: xtrkcad source: vcs-field-uses-insecure-uri vcs-git git://anonscm.debian.org/collab-maint/xtrkcad.git
>
> My option to not change git to https was to start a git-gui client
> directly. If you want I change it.
Are you saying that git-gui cannot use https URIs?
It's okay to keep git:// if it is more convenient for you.
> > I: xtrkcad: spelling-error-in-binary usr/bin/xtrkcad Minumum Minimum
>
> I have add a new patch 0900-spelling-errors.patch to correct the
> spelling error.
Thanks, and great work forwarding the patch.
> > It looks like you used wrap-and-sort -- please add this to the
> > changelog, so a future contributor knows which options to use. E.g.
> >
> > * Run wrap-and-sort -abst
You haven't added this to the changelog yet...
> >
> > You made changes to d/rules not documented in the changelog.
>
> sry. Also I don't have a git commit message. I have add a comment about
> this.
What do you mean about "git commit message"?
Changelog for d/rules LGTM.
>
>
> >
> > After making further changes, don't forget to re-run `dch -r`, and
> > please remove the moreinfo tag from this bug to put it back in my queue.
> >
> done
Ditto for this second review.
We are almost ready to upload.
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature