On 2016-12-08 06:35+1100, Dmitry Smirnov wrote:
> I had a glimpse at the package and it looks good except removed content of
> "gbp.conf" that I'll leave for Félix to fix (if he thinks it necessary).
>
> Félix, in "gbp.conf"
>
> ~~~~
> [dch]
> id-length = 0
> ~~~~
>
> is occasionally useful for "gbp dch".
From gbp-dch(1):
--id-length=N
Include N digits of the commit id in the
changelog entry. Default is to not include
any commit ids at all.
So, that's already the default, right? It could be modified by the user's
global gbp.conf, and it affects the changelog entries, so I set it back to this.
> The following fragment is to help building the package with GBP when upstream
> sources are not merged in "master":
>
> ~~~~
> overlay = True
> export-dir = ../build-area/
> tarball-dir = ../
> ~~~~
>
> Basically it instructs GBP to generate/use tarball and it might be useful for
> "debian"-only master repository layout.
I thinks that these should be set by the user's global gbp.conf. If he wants to
use "export-dir = ../debian-build-area" or anything else, we shouldn't override
this.
Does this address your concerns?
> Thanks.
Thank you!
Attachment:
signature.asc
Description: PGP signature