[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847650: RFS: fgetty/0.7-2



On 12/10/2016 10:43 AM, Gianfranco Costamagna wrote:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> 
>>  * Add dietlibc-dev into Built-Using, since it is linked statically,
>>    as mandated by Policy §7.8. (Closes: #847576)
> 
> 
> I'm not sure about hardcoding the version, this will probably break binNMUs...

Well, it's mostly a policy violation. If the non-binNMU'd version was
already in testing, the source package of dietlibc corresponding to
the hard-coded Built-Using header would still be around in testing,
so the binNMU could actually migrate there.

However, it'd be lying about the actual version of dietlibc used to
compile it, which means that'd be a policy violation, making the
binNMU rc-buggy. (Someone would have to file the RC bug manually
though.)

> what about calculating that at build time?
> https://sources.debian.net/src/virtualbox-ext-pack/5.1.10-4/debian/rules/
> this might work (see dh_gencontrol override and the control file)

As a co-maintainer of dietlibc and a maintainer of a package using it
I would recommend the following code in d/rules:

override_dh_gencontrol:
	dh_gencontrol -- -VBuilt-Using="`dpkg-query -f'$${source:Package} (= $${source:Version})' -W dietlibc-dev`"

And in d/control:

Package: ...
Built-Using: ${Built-Using}

See e.g. the tiny-initramfs package.

(Note that the Debian revision has to be included here for the
Built-Using header to follow policy, so doing cut -d- -f1 would be
wrong here.)

Regards,
Christian


Reply to: