[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847004: RFS: soci/3.2.3-2



Control: owner -1 !
Control: tags -1 moreinfo


Hi Bill,

Thanks for the update package!

here's the review:

Must-fixes:
- Please remove the -dbg package in favour of the automatic dbgsym
packages (https://wiki.debian.org/DebugPackage)
- Please update to latest standard's version
- lintian's complaining about not enabled hardening. Please check if
you can fix that. 
- would be nice if you could bump d/compat level to 10 (and cleanup
d/rules accordingly)
- please add 2016 to d/copyright for yourself (debian/*)

Should-Fixes:
- there is a spelling error lintian complains about (ment -> meant).
Can you check if this is valid and patch it out if so?
- seems so that github is now leading.. Maybe update the watch file to
follow github?

Wishlist:
- maybe ask upsteram to make another release? Seems so that upstream
worked a lot, maybe some fixes would be valuable to have...
(Needs careful checking to avoid SO-Name breakage, of course)
- There are many compiler warnings about unsafe float comparasion,
maybe upstream fixed this already, but if not this should be filed.
- can you look into the test suite, results are currently ignored.
- would be great if you could enable automatic package tests (see dep8,
ci.debian.net)


Thanks

--
tobi


Am Sonntag, den 04.12.2016, 15:57 -0500 schrieb Bill Blough:
> Package: sponsorship-requests
> Severity: normal
> 
>   Dear mentors,
> 
>   I am looking for a sponsor for my package "soci"
> 
>  * Package name    : soci
>    Version         : 3.2.3-2
>    Upstream Author : soci developers
>  * URL             : http://soci.sourceforge.net
>  * License         : Boost Software License - 1.0
>    Section         : libs
> 
>   It builds those binary packages:
> 
>  libsoci-core3.2 - C++ Database Access Library
>  libsoci-core3.2-dbg - C++ Database Access Library (debug symbols)
>  libsoci-dev - C++ Database Access Library (devel)
>  libsoci-firebird3.2 - C++ Database Access Library (Firebird backend)
>  libsoci-mysql3.2 - C++ Database Access Library (MySQL backend)
>  libsoci-odbc3.2 - C++ Database Access Library (ODBC backend)
>  libsoci-postgresql3.2 - C++ Database Access Library (PostgreSQL
> backend)
>  libsoci-sqlite3-3.2 - C++ Database Access Library (SQLite3 backend)
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/soci
> 
> 
>   Alternatively, one can download the package with dget using this
> command:
> 
>     dget -x https://mentors.debian.net/debian/pool/main/s/soci/soci_3
> .2.3-2.dsc
> 
>   More information about hello can be obtained from https://soci.sour
> ceforge.net
> 
>   Changes since the last upload:
> 
>     * Update build-depend to use default-libmysqlclient-dev (closes:
> #845909)
>     * Remove unneeded dh_clean override
> 
>   Regards,
>    Bill Blough
> 

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: