[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847458: RFS: clues-emacs/0~2014.09.23.69d873c-1 ITP



control: owner -1 !
control: tag -1 +moreinfo

Hello Dmitry,

Here's a review for you.  I also made two commits to your repository --
please see the commit messages for an explanation.  Hopefully you will
agree with the changes ;)

Must-fixes
==========

1. Your most recent changes are newer than the timestamp in the
changelog, so you need to re-run `dch -r`.

2. Your copyright for debian/ says 2014...

Suggestions
===========

1. It would be good to file a bug upstream asking for a tagged stable
release.

2. How about installing clues-theme.png, and patching README.md to refer
to it?

3. You could extract and install the upstream changelog from clues-theme.el

4. In the description,

s/on the other hand/, on the other hand,/
s/Roots'/Roots',/
s/despite it's/despite its/

5. Since there are not actually any tests, you could remove Testsuite:
from d/control.

6. Please use https:// not git:// in d/watch.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: