On 2016-11-26.15:48, Vincent Bernat wrote: > ❦ 22 novembre 2016 23:55 +1100, Scott Leggett <scott@sl.id.au> : > > > This is now ready, here are the changes since your last review: > > > > * Add automatic migration from -dbg to -dbgsym. > > * Add users/groups unconditionally to simplify preinst. > > * Create "quagga" metapackage. > > I would have removed the recommends for quagga-core package as it would > make more difficult for most people to only keep the daemons they need > and do not bring anything sensible compared to quagga/quagga-core > packages. Of course, that's quite subjective. > You're right - I've changed this to make the daemon packages Suggests rather than Recommends. > > * Use debhelper integration with dpkg-maintscript-helper. > > * Remove /etc/default/quagga. > > Should be removed with dpkg-maintscript-helper to alert the user there > was a change (and its modifications are now ignored). > Actually this file is not in the current quagga package - I added it during my adoption of the package but have now removed it again. > You could also remove README.Maintainer if it doesn't contain any > relevant information. There are also some bits of the README.Debian > about SNMP that are not up-to-date (some sentences just need to be > removed). > I updated README.Debian to remove references to old Debian releases. I'd like to keep README.Maintainer though, just because I did actually find it useful during adoption and I've added some more packaging notes in there. It doesn't end up in any package anyway - just in the repository. > Other than that, all is OK. Great! New packages are up at https://mentors.debian.net/package/quagga Changes since your last review: * Make daemon packages Suggests rather than Recommends of quagga-core. * Remove reference to old Debian release in README.Debian. * Avoid VCS files in packages. -- Regards, Scott.
Attachment:
signature.asc
Description: Digital signature