[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845018: Fwd: Re: Bug#845018: RFS: quagga/1.1.0-1 [ITA] -- network routing daemons



----- Forwarded message from Vincent Bernat <bernat@debian.org> -----

> Date: Mon, 21 Nov 2016 13:56:00 +0100
> From: Vincent Bernat <bernat@debian.org>
> To: Scott Leggett <scott@sl.id.au>
> Cc: debian-mentors@lists.debian.org
> Subject: Re: Bug#845018: RFS: quagga/1.1.0-1 [ITA] -- network routing daemons
> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
> 
>  ❦ 21 novembre 2016 23:39 +1100, Scott Leggett <scott@sl.id.au> :
> 
> >> >   * Use systemd .service files rather than init.d scripts (Closes: #678946,
> >> >     #805840, #839819, #412483).
> >> 
> >> I am quite OK with that. You don't have time to sort out those
> >> problems. However, this is somewhat controversial.
> >>
> >
> > I'm open to accepting patches / co-maintainership from anyone who wishes
> > to test and use traditional init scripts with quagga. Given the
> > longevity of bugs like #678946, I'm not optimistic of such patches
> > materialising.
> >
> > I personally cannot test such init scripts since all my systems now use
> > systemd, and I can't in good faith include code that I can't test and
> > which has known bugs.
> >
> > If there is another approach you think I could take here, please
> > advise...
> 
> People who want other people to keep init scripts alive are asking to
> just leave them be, even if they are buggy. That's not something I agree
> with, so I am happy that you just removed them. But you could get some
> opposition.
> 
> >>  - default/quagga could be called "quagga.default" and would be
> >>    installed automatically as /etc/default/quagga.
> >> 
> >
> > As this is now part of "quagga-core", I still have to install this
> > file manually as far as I can tell. Thanks for the tip on the debhelper
> > way to install it though.
> 
> dh_installinit should install it if you name it quagga-core.default.
> 
> >>  - the service files seem to use wrong paths. In Debian, chown is in
> >>    /bin, not /usr/bin.
> >> 
> >
> > This is interesting.. I ran `which chmod` on my unstable test box, and
> > got "/usr/bin/chmod". /bin is a symlink to /usr/bin in unstable now, and
> > /usr/bin is before /bin in $PATH.
> 
> It's because you have installed usrmerge. I don't think this is like
> this on a standard installation.
> 
> > The new package is available again at
> > https://mentors.debian.net/package/quagga
> 
> I'll review the changes for tomorrow.
> -- 
> Debian package sponsoring guidelines:
>  https://vincent.bernat.im/en/debian-package-sponsoring.html



----- End forwarded message -----

-- 
Regards,
Scott.

Attachment: signature.asc
Description: Digital signature


Reply to: