Bug#844734: RFS: dvbcut/0.7.1-1

[Bernhard Übelacker <bernhardu@mailbox.org>]

Hello Gianfranco,
thank you very much for sponsoring and your improvements.

I try to prepare a new package version.

Kind regards,
Bernhard



Am 18.11.2016 um 17:48 schrieb Gianfranco Costamagna:
> Hi, I'm sponsoring but please note something that is nice to have fixed:
> 
> dh $@ --buildsystem=autoconf --with=autoreconf,autotools-dev --parallel
> 
> this is useless with compat level 10 (at least it should be)
> please bump compat to 10 and debhelper >=10 :)
> also, consider dropping them as build-dependencies
> 
> 
> [ Bernhard Übelacker ]
> 
> 
> ^^ this line is useless in changelog you did all the changes here
> 
> 
> [ Bernhard Übelacker ]
> * Avoid redraw of intermediate steps while
> dragging sliders with the mouse.
> * Remove outdated Recommends mplayer2 and unused mpv.
> (Closes: #841183) Thanks to James Cowgill.
> * Add facility to search for duplicate frames (Thanks to Olaf Dietsche).
> * Remove some gcc 6 warnings.
> 
> 
> this is wrong: you should do something like
> * New upstream release 0.7.1
>   - fixes build failures/warnings
>   - add search duplicate foo
>   - allow bar
> 
> * Remove outdated Recommends
> 
> this would have split the fixes into "new upstream fixes" and "Debian specific fixes"
> 
> why does it runtime depend on
> libqt5gui5,
> libqt5widgets5,
> libqt5core5a,
> 
> ???
> 
> shlibs:Depends should already pick them up, I don't see dlopen or similar, so I think
> it should(TM) work
> 
> override_dh_auto_clean:
> [ ! -f Makefile ] || make -f Makefile distclean
> dh_clean dvbcut.desktop src/Makefile configure
> dh_clean
> dh_auto_clean
> 
> 
> why calling dh_clean in dh_auto_clean?
> 
> why overriding dh_auto_install?
> 
> probably not overriding it and removing the debian/*.install debian/*.dirs will result in the whole
> job done
> (or most of it, in case patch the pro file and submit the patch upstream)
> 
> http://debomatic-amd64.debian.net/distribution#unstable/dvbcut/0.7.1-2/buildlog
> 
> I did almost everything, I'll leave the last improvements to you if you want to adopt them
> 
> G.
>