control: retitle 832704 RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
Dear Boyuan,
On Sat, Nov 12, 2016 at 11:26:52AM +0800, Boyuan Yang wrote:
> Since the dependency qevercloud has entered unstable, it is perfectly
> fine to move towards nixnote2. I have prepared the 2.0~beta10 version
> of nixnote2 package, which should address previous problems.
Thank you for your efforts. There is only one issue blocking upload,
plus some other minor comments below. The blocker:
hephaestus ~ % nixnote2
QSqlDatabase: QSQLITE driver not loaded
QSqlDatabase: available drivers: QMYSQL3 QMYSQL
ERROR 2016-11-13 14:38:58.946 ( sql/databaseconnection.cpp @ 44 ) Error opening database: QSqlError(-1, "Driver not loaded", "Driver not loaded")
Any ideas?
> * Some minor modification to package description in debian/control.
1. There's a grammatical error in your change: s/provide/provides/.
2. The sentence doesn't really make sense. Maybe s/and/to/ is what you
meant?
> * Copyright information update for beta10 version.
3. Are you installing the plugins at present, 'hunspell' and 'webcam'?
Contents of package suggests not. Upstream seems to think they belong
in separate binary packages. What do you think about that?
> Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However
> since new gcc has already set -fPIE by default since 6.2.0-7, this
> should be harmless.
Yes. Lintian would be complaining if it wasn't being passed.
4. I'm curious why you nuked gbp.conf. Entirely up to you, of course.
5. Your Forwarded: headers got eaten at some point. Would be nice to
restore them.
6. You could install the new screenshot.png to
/usr/share/doc/nixnote2/examples (see dh_installexamples(1)).
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature