Bug#843669: RFS: eclib/20160720-3
Hi,
On 08/11/2016 17:55, Mattia Rizzolo wrote:
control: owner -1 !
control: tag -1 moreinfo
On Tue, Nov 08, 2016 at 05:40:45PM +0100, Julien Puydt wrote:
I am looking for a sponsor for my package "eclib"
o/
Vcs-Git:
https://anonscm.debian.org/git/debian-science/packages/eclib.git
* please kill the dh-autoreconf build-dep
Done.
* d/copyright looks outdated; at least your own copyright is, but please
look over all of it.
+ maybe stop mixing tabs and spaces so irregularly too?
* d/rules:
I tried to rework it.
+ could you instead inject the -D_LARGEFILE_SOURCE by using
dpkg-buildflags' means? (i.e. DEB_CPPFLAGS_MAINT_APPEND variable)
autotools should be able to deal with it correctly even without
passing it at configure time like that.
Well... now you mention it :
(1) it wasn't autotools-based when I made the package, so that might
explain why everything was passed to the "configure" script ;
(2) it's one of the first packages I made, so I might have had no real
clue what I was doing ;
(3) pbuilder says it compiles as well without it!
==> Conclusion: axed!
+ can't that thing be moved over to dh_auto_install instead of
manually calling make?
Well, since the move to autotools, I don't think that is necessary :
axed! And pbuilder is still happy.
- I cleaned d/rules with a rusty axe.
:)
I thought I might have cut a bit too much... now I don't think there's
much to remove. Still, if you think there's still some left, I'll gladly
give another swing. *g*
Thanks,
Snark on #debian-science
Reply to: