[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835253: marked as done (RFS: steghide/0.5.1-11 [QA])

Your message dated Mon, 10 Oct 2016 07:00:53 +0000 (UTC)
with message-id <2044890111.3457943.1476082853270@mail.yahoo.com>
and subject line Re: Bug#835253: RFS: steghide/0.5.1-11 [QA]
has caused the Debian Bug report #835253,
regarding RFS: steghide/0.5.1-11 [QA]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
835253: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835253
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal

Dear mentors,

  I am looking for a sponsor for the package "steghide"

 * Package name    : steghide
   Version         : 0.5.1-11
   Upstream Author : Stefan Hetzl <shetzl@teleweb.at>
 * URL             : http://steghide.sourceforge.net/
 * License         : GPL
   Section         : misc

  It builds those binary package:

    steghide   - A steganography hiding tool

  To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/steghide

  Alternatively, one can download the package with dget using this command:

    dget -x https://mentors.debian.net/debian/pool/main/s/steghide/steghide_0.5.1-11.dsc

  Changes since the last upload:
  
  * QA upload.

  [ Aurelien Jarno ]
  * debian/rules: added dh_autotools-dev_updateconfig and
    dh_autotools-dev_restoreconfig to fix FTBFS on new architectures
    such as arm64 and ppc64el. Closes: #759453

  Regards,
   Fernando Seiti Furusato

--- End Message ---
--- Begin Message --- 
Hi Fernando, sorry for taking long to reply!

>I tried to to that. But then I had to add doxygen as a build-dep.


corect, and I moved it to Build-Depends-indep, to avoid it being picked
up by every architecture instead of only arch:all builders
(I tried a dpkg-buildpackage -B on ppc64el and it worked without it)

>Corrected that.


nice

>Well, I just used the same commands, just not the make install part.

I see, I changed it to be this way:
-       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/INSTALL
-       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/INSTALL.gz
-       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/COPYING
-       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/COPYING.gz
+       rm -f $(CURDIR)/debian/steghide/usr/share/doc/steghide/INSTALL
+       rm -f $(CURDIR)/debian/steghide/usr/share/doc/steghide/INSTALL.gz
+       rm -f $(CURDIR)/debian/steghide/usr/share/doc/steghide/COPYING
+       rm -f $(CURDIR)/debian/steghide/usr/share/doc/steghide/COPYING.gz


and removed that dh_auto_install at the begin of dh_install
(when dh_install starts, auto_install is already finished, and recalling it
is a no-op or a bug, I don't remember :) )
>I talked to Breno last week, he said he might not have time to do this
>and it would
>be fine if you sponsored this one.


fine by me

>If you could take a look I would appreciate.
>
>It can be found at the same place:


I sponsored it in deferred/5, after doing some more changes (sorry, but I couldn't resist)
-    - Bumped compat level to 9
+    - Bumped compat level to 10
+      this adds with --with-autoreconf to update config.{guess,sub}
+      and fix FTBFS on architectures such as ppc64el.
+      Closes: #759453, #535842


compat level 10 is awesome (and I'm trying it for my first time)


dh_autoreconf is a dependency now, so it can be dropped from build-dependencies, as well
as the --with-autoreconf.

debian/dirs was useless, seems usr/bin is correctly created.

Other stuff was good enough for me,
(I also had to change the doc description, to avoid a "duplicate long description lintian warning)

Other config.sub and config.guess warnings seems harmless, since I tried a ppc64el porterbox
successfully

I'm attaching the debdiff on top of your changes, the one sponsored on ftpmaster.
You can also grab the file from there
http://debomatic-amd64.debian.net/distribution#unstable/steghide/0.5.1-11/contents


Last things (for a future upload) seems to be:
1) autoreconf foreign patch.
I remember some rules export that pass --foreign to autoreconf, even if I can't remember
which one

2) hardening might be something nice to enable, but I didn't try it.

cheers,

G.

Attachment: debdiff
Description: Binary data


--- End Message ---
Reply to: