[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#838941: RFS: duperemove/0.11~beta3-3 ITP



On Wed, Sep 28, 2016 at 11:24:20AM +0200, Dariusz Dwornikowski wrote:
> On 26 September 2016 at 23:12,  <peter.zahradnik@znik.sk> wrote:
> >  * Package name    : duperemove
> >    Version         : 0.11~beta3-3
> 
> "When given the -d option, duperemove will submit those extents for
> deduplication using the btrfs-extent-same ioctl."

It's a vital piece of information, as without this option duperemove does
nothing but waste CPU and I/O.  An user would be able to use it intuitively
otherwise.

I have no idea why dry run is the default (probably from early debug
times?), but compared to most similar programs, the output is pretty
useless for purposes other than deduplicating, as duperemove does some
heurestics and thus its results are incomplete.

Thus, this option is needed to get started.  On the other hand, perhaps it
could be better to make a patch to switch the logic and have a --dry-run
option instead?

-- 
A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, 1kg
raspberries, 0.4kg sugar; put into a big jar for 1 month.  Filter out and
throw away the fruits (can dump them into a cake, etc), let the drink age
at least 3-6 months.


Reply to: