Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --
control: owner -1 !
control: tags -1 moreinfo
Hi,> * Non-maintainer upload.
changes are huge, but being half mia, and on lowNMU threshold...
(and too many bugs here, so lets do it)
> * New upstream release (closes: #833081, #811988, #798624, #645616).> * Updated to Standards-Version 3.9.8 (no changes required).
> * Updated to debhelper 9, updated Build-Depends.
> * Added Multiarch support.
> * Updated debian/*.install and removed the install directory where
>source and
> destination directories are the same.
> * Added patch to generate non-empty index.html in the documentation.
> * Removed old-style config file.
> * Commented out the broken Vcs URLs in debian/control.
review:
1) have patches been upstreamed?
2) patch description might be nice / patches should follow dep3 and
please don't remove the original fields (e.g. author)
http://dep.debian.net/deps/dep3/
3) d/p/003-no-old-style-config.patch
you are using autoreconf and this patch is patching Makefile.in
this means that the patch will touch a file that is autoregenerated.
So, in case please patch Makefile.am
4) automake, libtool, doxygen, dh-autoreconf
doxygen might be needed only for arch:all builds, so you might want to move
it into Build-Depends-Indep
(probably it won't work, since you seem to build documentation also in arch:any builds)
5) automake, libtool, are them useful?
6) new files
diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.dirs libcgicc-3.2.16/debian/libcgicc-dev.dirs
--- libcgicc-3.2.9/debian/libcgicc-dev.dirs 1970-01-01 01:00:00.000000000 +0100
+++ libcgicc-3.2.16/debian/libcgicc-dev.dirs 2016-09-08 20:41:26.000000000 +0200
@@ -0,0 +1 @@
+usr/include
diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.install libcgicc-3.2.16/debian/libcgicc-dev.install
--- libcgicc-3.2.9/debian/libcgicc-dev.install 1970-01-01 01:00:00.000000000 +0100
+++ libcgicc-3.2.16/debian/libcgicc-dev.install 2016-09-08 20:41:26.000000000 +0200
@@ -0,0 +1,4 @@
+usr/include/*
+usr/lib/*/lib*.so
+usr/lib/*/pkgconfig/*
+usr/share/pkgconfig/*
why?
I have to say I wouldn't oppose too much a rename of the binary from
libcgicc5-dev to libcgicc-dev, but this means going in bin-new queue,
and I would take the opportunity on the next SONAME bump.
(there aren't reverse-dependencies)
7) /usr/bin/cgicc-config
this was shipped before, why are you removing it?
8) library changed soname?
from
libcgicc.so.5.0.2
to
libcgicc.so.3.2.10
not sure what happened, but this seems bad
objdump -p ../libcgicc.so.3.2.10 |grep -i SONAME
SONAME libcgicc.so.3
soname going backward is somewhat bad.
(unless somebody has a better opinion, probably it doesn't mean
too much, but for sure the binary needs to follow the SONAME change).
Please investigate this with upstream, according to their changelog
they did something wrong and tried to recover from it.
(changing SONAME for this seems a good reason, and will integrate
the Ubuntu patch too, at least in some little way, as well
as the -dev package renaming)
thanks!
G.
Reply to: