On Mon, Aug 29, 2016 at 07:17:47 +0000, Gianfranco Costamagna wrote: > control: owner -1 ! > control: tags -1 moreinfo > > Hi, > > >I'm looking for an sponsor for my updated package python-jsmin > > > pull-debian-source python-jsmin > > dget -u https://mentors.debian.net/debian/pool/main/p/python-jsmin/python-jsmin_2.2.1-1.dsc > > debdiff python-jsmin*.dsc > debdiff > > lets look at the debdiff file: > > 1) + * Bump standards version. No changes needed. ok > > > I would also say to which version, otherwise it will become useless after two or three bumps > > > 2) + * Change my name on the control file to match the changelog. > > > not a problem, but I would change both to have the first char as upper-case, instead of using > all lowercase for your name > > > 3) you are adding entries to a previous changelog entry > + * Add pristine-tar to source VCS. > > > (this appears to be a change in *this* release) > > > 4) and changing one signature date of some old release > > - -- Gustavo Panizzo <gfa@zumbi.com.ar> Wed, 23 Dec 2015 22:46:59 +0800 > + -- Gustavo Panizzo <gfa@zumbi.com.ar> Thu, 14 Jan 2016 23:46:59 +0800 commit b9bd75f323f772460e07da19d875ee8366f93bdf is to blame, I did the change that. I guess the uploader didn't pull after I pushed. good catch, thanks > > python-all (>= 2.6.6-3~), > + dh-python, > > > ^^ there is a <TAB> > instead of spaces (this makes vim sad) done, i'm surprised wrap-and-sort didn't fix it > > I admit, they aren't really blockers, and the problem is in the git repo, where somebody > committed something different from the version that has been uploaded in Debian. > But I would take the opportunity to fix it once for all, starting from this version. > > What do you think about? I've pushed again to alioth and mentors, thanks for your review > > G. -- 1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333 keybase: https://keybase.io/gfa
Attachment:
signature.asc
Description: PGP signature