Bug#835658: RFS: backbone/1.3.3+ds-1
Hi,
On 28/08/2016 10:00, Gianfranco Costamagna wrote:
control: owner -1 !
control: tags -1 moreinfo
(ccing people who expressed interest in this update)
I am looking for a sponsor for the package "backbone"
here we are, but I have some questions/issues:
1) why did you drop so much build-dependencies?
I don't know why there was that much - pbuilder is happy with what I put.
2) missing copyrights/licenses:
* @license RequireJS 2.1.9 Copyright (c) 2010-2012, The Dojo Foundation All Rights Reserved.
* Available via the MIT or new BSD license.
(c) 2009-2015 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
and maybe more
I don't have the time to look into that just now.
3) Did you get in touch with the maintainer for this upload?
Contrary to what I usually do, no : I saw two "please package new
upstream" bugs, both old (may 2014 and september 2015), none closed as a
duplicate of the other -- so I considered the "getting in touch" step
was done and pushed forward with the "team maintenance" step.
4) please tag the two bugs as pending, to avoid double work from other people
(e.g. zigo who expressed)
Done.
5) I'm not sure Jonas will like to move away from cdbs...
That was the first time I met a cdbs package... isn't it deprecated?
6)
-Author: Jonas Smedegaard <dr@jones.dk>
+Author: Julien Puydt
I would use both people as authors :)
Ah, that is because I rewrote the patch by hand (didn't apply... perhaps
just because they changed the order of the lines), then added mly usual
header. Added back.
7) depends/buil-depends.
typo
Fixed.
8)
Bump standards-version.
To which version?
Added.
9)
"This source package uses CDBS"
I would change that :)
git rm README.source... but I seem to have forgotten a git commit -m
somewhere so it doesn't appear in history... drat.
10)
why is this a ds repack? it seems to be not written in README.source
or whatever
Well, that is documented in debian/copyright, as usual:
Files-Excluded: *-min.js
and it's automatic, with debian/watch having the repacksuffix=+ds options.
11) compat level is still 8 :)
Fixed.
we should be mostly complete as a preliminary review.
I have to admit, the cdbs rules file was a little bit complicate for a 3 installed
js files library :)
I admit I didn't even try to understand what it did : just saw how big
it was, removed the file and started from scratch.
but I think we might go for experimental, wait some more testing for the two+ people needing
it and then go for unstable.
Done.
Does it sounds good as a plan
Yes.
I'll have to find the time to take care of d/copyright.
Thanks,
Snark on #debian-js
Reply to: