control: owner -1 !
control: tag -1 moreinfo
On Thu, Aug 18, 2016 at 10:24:31PM +0200, Elena ``of Valhalla'' Grandi wrote:
> On 2016-08-18 at 21:48:05 +0200, Elena ``of Valhalla'' wrote:
FYI: no need to explicitly CC d-mentors@, RFSes are somehow sent there
anyway.
> > To access further information about this package, please visit the following URL:
> >
> > https://mentors.debian.net/package/codicefiscale
> >
> >
> > Alternatively, one can download the package with dget using this command:
> >
> > dget -x https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9-1.dsc
> >
> > Or directly from git at:
> >
> > https://anonscm.debian.org/git/python-modules/packages/codicefiscale.git
>
> sorry, I forgot about removing the codicefiscale.egg-info, the actual
> dsc is:
>
> dget -x https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9+ds0-1.dsc
>
> (all other urls are ok, and their content have been updated, sorry)
This is DPMT, where the usage of git is mandated, so I expect the git
repository to match the generated .dsc (hence I'm ignoring mentors here)
A few small things I'd like to see:
* you email address in d/copyright
* Files-Excluded in d/copyright doesn't list all the files that are
removed (at least according to `git diff --stat
upstream/0.9..upstream/0.9+ds0`)
besides, wrapping that list might not be a bad idea
* Also would be nice to see Build-Depends wrap-and-sort'ed
* python3-codicefiscale uses ${python:Depends} instead of
${python3:Depends}
* why do you disable the tests? (a comment on d/rules might not be a
bad idea here either)
+ I see setup.py lists non-existant tests, if that's the issue maybe
you can get that tests= arg removed (or the actual tests included)
upstream?
* in d/watch, you dversionmangle '.ds0' away, but you're using '+ds0'
actually, so it's not actually mangling anything
* just quickly skimming over the README, I think it would make sense to
include in the binaries, as it provides quick documentation (I think)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature