[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833187: RFS: yuma123/2.8-1 [ITP] -- netconf/YANG toolchain



 ❦  8 août 2016 03:00 CEST, Vladimir Vassilev <vladimir@transpacket.com> :

>>   - d/watch: missing, please add one. It allows you (or me) to
>>     conveniently know if there is a new version available. This appears
>>     on various tools like tracker.debian.org or qa.debian.org.
> [1] fixed

There is a slight error in it. You use "~" instead of "+", so it doesn't
work. You can test with "uscan --report --verbose". It should say:

uscan info:    => Package is up to date for from
      https://qa.debian.org/watch/sf.php/yuma123/yuma123_2.8.tar.gz

>>   - d/control: no need to Build-Depends on autotools-dev, dh-autoreconf
>>     already does everything.
> [2] ! did try to remove autotools-dev but lintian was reporting error
> without it. With updated pbuild environment.

Ack.

>>   - you may want to add a libyuma2.symbols file. It can be generated with
>>     dpkg-gensymbols (and modified manually to remove the debian part of
>>     the version number).
> [16] !(generated the file 2067 lines, 63576 bytes. The "may" you use
> and the size of the file tilted the scales on deciding not to add a
> libyuma2.symbols file if you do not have it as a mandatory
> requirement)

Ack.

>> .Some other files are generated
>>  From the MIB. You cannot use them, sorry. There may be some debate here
>> as MIB are used as an interface documentation. However, they are really
>> non-free material. Maybe bringing this to debian-legal@ may help.
> [18] resolved by removing all MIBs and products generated from MIBs
> from 2.8+dfsg

You need to document in some way how you got this +dfsg tarball from the
original tarball. The easiest way is to use the Files-Excluded field in
debian/copyright. You can find more details in the manual page of
uscan. This way, uscan will be able to download and repack the tarball
itself. Have a look at the repacksuffix option too (to add +dfsg). The
other way is to have a "get-orig-source" rule in the Makefile.

Also, another detail, in d/changelog, you need to close the ITP, not the
RFS. The RFS will be closed once the package is uploaded. The ITP needs
to be closed once the package reaches the archive, through
debian/changelog.

For a first upload, keep d/changelog with just "Initial release
...".

Otherwise, everything is OK.
-- 
Debian package sponsoring guidelines:
 https://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: