[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834078: RFS: python-argh/0.26.1-1.1 [NMU, RC] -- simple argparse wrapper



control: reopen -1
control: retitle -1 RFS: python-argh/0.26.1-1.2 [NMU] -- simple argparse wrapper
control: severity -1 normal

Hello,

On Fri, Aug 12, 2016 at 02:22:09PM +0200, Jakub Wilk wrote:
> Both the original and the new patch look wrong to me:
> * C is not the only locale in which the test fails.
> * You can't determine the current locale just by looking at the LANG
> variable. (It can by overridden by various LC_* variables.)
> 
> Ideally the test should be fixed upstream[0], but until then it's probably
> best to drop this half-baked patch, and instead force UTF-8 locale in
> debian/rules (export LC_ALL=C.UTF-8).

I agree -- thanks for your feedback.  I'm reopening this RFS for another
NMU (this time, I would like to suggest an upload to DELAYED/10).

New changelog:

  * Non-maintainer upload.
  * Drop parts of 0001-fix-unit-tests.patch touching test_interaction.py.
  * Fix the Unicode encoding test by setting LC_ALL in d/rules.
    This fix is more general as the LANG var can be overridden by LC_*
    vars (see locale(7)).  Thanks to Jakub Wilk for pointing this out and
    suggesting the improved fix.

Download from mentors:

    dget -x http://mentors.debian.net/debian/pool/main/p/python-argh/python-argh_0.26.1-1.2.dsc

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: