control: tag -1 moreinfo
control: owner -1 !
On Sun, Aug 07, 2016 at 02:49:38AM +0100, Jerome Benoit wrote:
> [1] https://anonscm.debian.org/cgit/debian-science/packages/libgap-sage.git
d/*.lintian-overrides + d/*.README.Debian:
you use the word 'furnished', which really means "providing
forniture" (or "provided with forniture"), afaik. I'm positive Debian
doesn't ship forniture :D
I think you meant 'provided' there.
debian/adhoc/doc/libGAP.pdf:
you provide that pdf, which is bad:
pdf are not considered sources (of course), you'd need to have the
sources near it, and possibly build it during the build process. PDFs
are also listed in the REJECT-FAQ; that said, I saw pdf in the archive
before, and I personally don't have hard feeling towards them, so if
you want I can try to upload it nonetheless.
upstream-autotoolization-test-systemwide.patch + upstream-autotoolization-header_folder.patch
s/hardden/harden/ (in the description)
debianization.patch:
i think these kind of patches like 'Forwarded: not-needed'
debianization-pkgconfig.patch
s/surch/such/ (in the description)
d/copyright:
i see several files in src/ with this header:
*Y Copyright (C) 1996, Lehrstuhl D für Mathematik, RWTH Aachen, Germany
*Y (C) 1998 School Math and Comp. Sci., University of St Andrews, Scotland
*Y Copyright (C) 2002 The GAP Group
those are not rapressented in your copyright.
That said, your work is as usual outstanding :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature