Bug#832934: RFS: pylucene/4.10.1+dfsg-1

[Gianfranco Costamagna <locutusofborg@debian.org>]

Hi,


>Now (new version) actually uses liblucene4.10-java from Debian both as
>Build-Depends and runtime dependency.
>And that's actually why I've added more Build-Depends. 
>
>lucene-java-4.10.1 is just there because it's in upstream tarball. 
>I was trying to avoid repackaging of upstream tarball (until I found
>minified JS files).
>
>It should be possible to completely exclude whole 'lucene-java-4.10.1'
>directory (and probably embedded copy of jcc source) from repacked
>orig.tar.gz. 
>
>Should I do this?


I usally prefer to avoid a repack wheneveer possible, but since you already did
it I would just remove that too.

rationale is:
the pylucene directory is ~75MB now

I removed that lucene-java directory and now it is around ~1MB

so, there is something like a 99% reduction

also the tarball is sensibly better
-rw-rw-r-- 1 locutus locutus 28M lug 29 19:50 ../pylucene_4.10.1+dfsg.orig.tar.gz


-rw-rw-r-- 1 locutus locutus 134K lug 30 11:27 ../pylucene-4.10.1+dfsg.tar.xz



many people will thank you for such reduction
1) myself, because I usually use mobile data connection to sponsor stuff
2) the archive, because less space will be needed
3) the end users who wants to rebuild the package

>As far as I understand, pylucene don't use it (at least directly). Since
>it's inside lucene-java-4.10.1 that is completely not used.


exacly, another reason for dropping it :)

>> pylucene-4.10.1+dfsg/debian/source/include-binaries ^^ please remove
>
>ok


I guess this has been added when you ran dpkg-source --commit without prior cleaning
the build dir :)

>I've mentioned about liblucene4.10-java in changelog:
>
>  * Drop embedded copy of lucene-java-4.10 in binary package (add Depends:
>
>      liblucene4.10-java)>
>
>Is it enough? Will check other dependencies


some additional notes:


a) dropping lucene-java will also fix the missing copyright entries I guess

b) I tried a rebuild without it and so far so good

c) about additional dependencies I see added:
Build-Depends: dh-python, curl, antlr3, liblucene4.10-java, libasm4-java

I understand dh-python, liblucene4.10-java, but I don't see a rationale for the others.

d)

you seem to have an embedded jcc copy...
not sure if possible, but dropping it brings the orig tarball size around 60KB
(the build is good after dropping it

last showstopper

e)
python-lucene: broken-symlink /usr/lib/python2.7/dist-packages/lucene/extensions.jar -> /build/pylucene-E6rl3V/pylucene-4.10.1+dfsg/debian/python-lucene/usr/share/python-lucene/extensions.jar

you seem to have a broken symlink.

that should be *really* all :)

G.