On 27-07-2016 13:14, Gianfranco Costamagna wrote:
> Lets finish the review:
> 1)
>
> grep copyright . -Ri
>
> missing people
Who missing? I've checked, it's okay.
> 2)
> debian/upstream/changelog
>
> what^
> 3) did you forward patches upstream?
forwarded the changelog? His changelog is merged into spec file.
>
> if you can fix/answer the above I think we are good
>
> check-all-the-things review:
> $ codespell --quiet-level=3
> ./config.c:169: unkown ==> unknown
> ./lsm.c:137: occured ==> occurred
> ./lsm.spec:825: lisence ==> license, licence
It is a false-positive, because the changelog is merged into this file,
so it's fix report in changelog.
> ./debian/lsm.init:12: conection ==> connection
> ./debian/upstream/changelog:695: lisence ==> license, licence
this file is extract from changelog, so is the same one above.
I'll fix the others.
>
> $ find -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname _sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o -iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname '*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' \) -exec env PERL5OPT=-m-lib=. spellintian --picky {} +
>
>
> $ env PERL5OPT=-m-lib=. uscan --report-status --no-verbose
> uscan: Newest version of lsm on remote site is 1.0.5, local version is 1.0.4
> uscan: => Newer package available from
> http://lsm.foobar.fi/download/lsm-1.0.5.tar.gz
About that, it's a new version with some patches I've forwarded.
I'll wait for this version get in Debian to investigate the new version
changes.
> G.
--
Lucas Castro
Attachment:
signature.asc
Description: OpenPGP digital signature