Bug#829151: RFS: setcolortemperature/1.1-1 ITP
control: retitle -1 RFS: setcolortemperature/1.3-1 ITP
On 07/08/2016 12:29 PM, Gianfranco Costamagna wrote:
>
> the package is quite simple, but I would appreciate something more
> verbose when calling it with wrong parameters.
> e.g.
> sct
> sct -h
> sct -v
> sct 10
> sudo sct 10
> sudo sct 14
>
> all gives no output.
>
> After reading the manpage I discovered that numbers should be within a range.
>
> I would appreciate a little help, and some error messages when bad input is provided.
This has been fixed. Now when -h is passed usage is printed and if the
temperature passed is wrong usage will also be printed.
> other issues:
> $(CC) sct.c $(CFLAGS) $(LDFLAGS) -Wall -lX11 -lXrandr -o sct
>
>
> missing CPPFLAGS
>
> LDFLAGS should go at the bottom, to avoid link failures with wl,asneeded
> (e.g. on Ubuntu where it is the default)
Fixed.
> there is a missing license in the tarball, please ask upstream to provide one
Added.
> other stuff LGTM
>
> G.
>
--
Jacob Adams
GPG Key: AF6B 1C26 E2D0 A988 432B 94F4 24C0 2B85 B59F E5A9
Reply to: