[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#829605: RFS: aspell-sk/2.02-0-0.1 [RC, NMU]



On Tuesday 05 July 2016 01:17:39 Jakub Wilk wrote:
> Control: owner -1 !
> Control: tags -1 + moreinfo
> 
> * Pali Rohár <pali.rohar@gmail.com>, 2016-07-04, 18:13:
> >dget -x
> >https://mentors.debian.net/debian/pool/main/a/aspell-sk/aspell-sk_2
> >.02-0-0.1.dsc
> >
> >Changes since the last upload:
> >  * Non-maintainer upload.
> >  * New upstream release (Closes: #603719).
> 
> debian/copyright says that the package "was downloaded from
> ftp://ftp.gnu.org/gnu/aspell/dict/sk/";, but there is no 2.02-0 at
> this location.

Official website for aspell-sk is http://www.sk-spell.sk.cx/aspell-sk 
where is also last version. On gnu.org is not last version and upstream 
maintainer confirmed it.

> BTW, what's the difference between 2.01-2 and 2.02-0? There's no
> entry for the latter version in doc/CHANGELOG. :-\

There is small changelog entry at website, that dictionary was updated 
to Firefox/Thunderbird version.

Quick look at diff between those two versions confirm it. Dictionary is 
updated (new words + some fixes).

> Also, the copyright file says that the package is under GPL, whereas
> this new version is tri-licensed: LGPLv2.1, GPLv2, MPLv1.1.

Ok, I can update debian/copyright file.

> >  * Use compat level 9 (Closes: #817360).
> 
> Did you need to do any packaging changes to bump compat?

Depends on debhelper 9, no other changes were needed, package built fine 
and is working.

> >  * Add Homepage and update Standards-Version.
> 
> Why are these two in a single item? They seem unrelated to me.

Those were changes in (one) control file, so I added them to one line.

> Did you need to do any packaging changes to update S-V?
> I wouldn't recommend updating S-V in an NMU.

Well, Debian has in archives very old (maybe prehistoric) version of 
aspell-sk package. I reported this problem in bug 603719 in past *six* 
years ago and everybody in Debian ignored it, current maintainer too.

And now when I saw that aspell-sk package is going to be removed from 
Debian, I updated compat level and thought that bringing new version 
should be done too...

> Addition of debian/watch is not documented in the changelog.

I can add it.

> You changed source format to "3.0 (quilt)", but this change is not
> documented either. Also, changing source format is not suitable for
> an NMU, unless you have a very good reason.

I thought that "3.0 (quilt)" format is preferred for new packages, so I 
updated it when I touched aspell-sk package.

-- 
Pali Rohár
pali.rohar@gmail.com

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: