On 05-Jul-2016, Gianfranco Costamagna wrote: > > >Can you point me to specific parts that you want to be cleaner, and how > >they should be cleaned? > > your rules file is 83 lines, most node packages are about 3-4 lines > e.g. > https://sources.debian.net/src/node-recast/0.11.4-2/debian/rules/ Thanks for the pointer to what you mean. Okay, the extra content in the ‘debian/rules’ I have written are for: * Documentation. I hope you won't begrudge some descriptive comments. * Implementing the target recommended by Policy §4.9, and explaining why this is needed. Rather than ignore Policy in this regard, until that clause is changed I would prefer to conform if there is no good reason not to. * Compiling the library from source. Upstream ships a pre-compiled library, so that is needed in the binary package. The example you point to seems to not install any compiled library files, so naturally this package will be more complex for doing more. > ping back when happy with your changes :) Is there anything else that you think should not be in the ‘debian/rules’ file? > (I can understand you like your current rules file, this isn't a > showstopper, I'm just a fan of "keep it simple") Me too; but where there needs to be something different from the default, I am also a fan of “explicit is better than implicit”. -- \ “Pinky, are you pondering what I'm pondering?” “Wuh, I think | `\ so, Brain, but how will we get three pink flamingos into one | _o__) pair of Capri pants?” —_Pinky and The Brain_ | Ben Finney <ben@benfinney.id.au>
Attachment:
signature.asc
Description: PGP signature