Bug#827907: RFS: evil/1.2.12-1 ITP
> > > > > Nice work. Have you forwarded the fix upstream?
> > > > Too much trouble. To fix it upstream, they have to deal with either:
> > > > * evil mode is autoloaded, interactive and with sane description. Ugliness
> > > > in code.
> >
> > > Do you know whether the problem if Debian-specific, or if it also arises
> > > when installing evil from MELPA?
> >
> > On MELPA everything is smooth.
>
> Are you sure about this? I tested myself, and the same problem occurs:
> M-x evil-mode doesn't work, although M-x describe-function evil-mode does.
Yes, I do.
> I consider this an upstream bug. Although most users will call
> `evil-mode' in their init file, one of the reasons for using the
> package.el packaging format is that a user can just do `M-x
> package-install evil RET M-x evil-mode RET' to quickly try out a new
> mode without doing any config.
>
> Since we have fixed this bug in the Debian package, we ought to forward
> our work upstream. Since we fixed it by some code in d/rules, we can't
> just send a patch they can apply. So I suggest that you file an
> upstream bug report, explain what you did to fix the problem for the
> Debian package, and put a link to that bug report in the Forwarded:
> header of the patch and also as a comment in d/rules.
Can you please report upstream yourself? I can't reproduce bug via MELPA.
See:
* If I build without my patch, the following autoload form will appear in
evil-autoloads.el
(autoload 'evil-mode "evil")
Note the lack of third and forth arguments, description and
interactive markers.
* With my patch, and before sed, we have following autoload:
(autoload 'evil-mode "evil-core" "\
Toggle Evil-Local mode in all buffers.
With prefix ARG, enable Evil mode if ARG is positive;
otherwise, disable it. If called from Lisp, enable the mode if
ARG is omitted or nil.
Evil-Local mode is enabled in all buffers where
`evil-initialize' would do it.
See `evil-local-mode' for more information on Evil-Local mode.
\(fn &optional ARG)" t nil)
Note that "evil-core" is autoloaded -- file where evil-mode is defined,
but not while evil suite.
* And here is autoload from my
~/.emacs.d/elpa/evil-20160227.711/evil-autoloads.el:
(autoload 'evil-mode "evil" "\
Toggle Evil-Local mode in all buffers.
With prefix ARG, enable Evil mode if ARG is positive;
otherwise, disable it. If called from Lisp, enable the mode if
ARG is omitted or nil.
Evil-Local mode is enabled in all buffers where
`evil-initialize' would do it.
See `evil-local-mode' for more information on Evil-Local mode.
\(fn &optional ARG)" t nil)
Everything is perfect. #'evil-mode autoloads whole evil suite.
> Another thing :) I don't think you need to invoke find(1) in d/rules.
> You can just do something like this:
>
> sed -i 's#foo..' debian/elpa-evil/usr/share/emacs/site-lisp/elpa-src/evil-*/evil-autoloads.el
>
> That's more explicit and easier to understand.
Done.
--
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io
Reply to: