[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#827037: RFS: xpad/4.8.0-1 [ITA]



control: tags -1 pending

> control: tag -1 +confirmed

Hi Sean, thanks for the really nice review!

I did sponsor on deferred/5, because I would like to have a feedback about the following

>    + remove build-depends on libgtk2.0-dev, libmagickcore-extra,
>      autotools-dev, imagemagick.


mmm why? I mean imagemagick and libmagickcore-extra, can you please provide a rationale for
their removal?
I don't see a bug or a removal request, so I would like to be sure about that

btw removing that will probably allow me to do a sync --force in Ubuntu, because you seem to have
incorporated all the Ubuntu delta here
https://bugs.launchpad.net/ubuntu/+source/xpad/+bug/635871

Did you check the delta too?
https://patches.ubuntu.com/x/xpad/xpad_4.5.0-0ubuntu1.patch

it might be nice to see if they have other fixes...

thanks for your hard work!

BTW I also think somebody will thanks you for the work you did :)
https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2016-June/016626.html

I didn't update it just because I didn't find the orphan bug
(ccing gilir, he might want to give an additional review here, even if the package is already on its
way for unstable)

Gianfranco

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: