[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825532: RFS: shadowsocks-libev/2.4.6+20160526+ds-1 [ITP]



Hi Roger

>Packaging another library (libipset) just takes some time.


I can understand that, and my review will probably take some more time :)
>Technically yes, but since it's a quite old version, I think nobody would do it.
>And currently "shadowsocks" is a python program in Debian archive, we don't recommend to install the old C-written shadowsocks.


wonderful

>So I packaged it and filed ITP#827080 / RFS#827082.>Hope you can also sponsor it.


sure, and I reviewed it

>Thanks for your detailed tips!>I just remove the text after "-delete", others are just as what you said.
>Works fantastic!


:)

>>It's runtime config file, which will be installed to: etc/shadowsocks-libev
>
> not sure about hardcoding passwords that way... maybe generate them at install
> time with apg or similar?
> (postinst or similar)
>
> I don't want all the userbase to have the same tool with the same default password.

>Done.
>Add postinst script to handle this.


>I like that solution!


but shouldn't this be executed only during install?
the place where you put suggests the code will be executed and re-executed during all
the calls (configure deconfigure abort upgrade and so on)

I would do it in configure, and don't care about the upgrade, because even re-running
it will be a no-op (unless apg generates the same "barfoo!" password :) )
LOL, in that case it will be changed during an apt-get {dist-}upgrade :)

>Hope you cannot find a nitpick this time :-P

there is always something to nitpick :)

e.g. 
https://mentors.debian.net/package/shadowsocks-libev
"W debian-watch-file-should-mangle-version
line 7"

what does it mean?
I admit I didn't investigate it

Gianfranco


Reply to: