[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#827487: RFS: circle/2.2-1 [ITP]



Hi Adam,

Thank you for your review.

I've hopefully patched all issues.
As per #827555 suggestion, I've changed package name to bytes-circle.

Greetings


2016-06-17 1:06 GMT+02:00 Adam Borowski <kilobyte@angband.pl>:
Control: tag -1 moreinfo

On Thu, Jun 16, 2016 at 11:50:02PM +0200, Roberto S. Galende wrote:
> I am looking for a sponsor for my package "circle"
>
> Package name    : circle
> Version         : 2.2-1
> URL             : http://wp.me/p2FmmK-96
>
> circle     - Show byte statistics as an ascii circle graph

Hi!
First, please file an ITP bug (via "reportbug wnpp").  This is no mere
formality, as it lets readers of debian-devel make comments with respect to
your plans.


debian/changelog:
* "This is my first Debian package." is a comment that doesn't belong in the
  changelog.
* please "(Closes: #<ITP bug number)" to the "Initial release" line.

debian/README.Debian:
debian/README.source:
* please delete, there's no non-boilerplate content

debian/control:
* please set Standards-Version to 3.9.8
* typo: ascci -> ascii
* the long description could use some elaboration

debian/copyright:
* please delete the boilerplate comments, they don't apply
* [nitpick] Files: * already includes Files: debian/*

debian/rules:
* all commented out boilerplate other than #DH_VERBOSE = 1 (somewhat useful
  as a reminder while debugging) should be axed
* you may want to uncomment some, though: hardening, -Wall

debian/circle/1:
* s/SECTION/1/
* again, s/ascci/ascii/

Otherwise, the package builds correctly and seems to work.


Please use "lintian" both on source and binary packages and address problems
it reports before uploading.  Using "lintian -i" will give quite helpful
hints how to fix them.


Meow!
--
An imaginary friend squared is a real enemy.


Reply to: