Hi, Thank you reviewing! I've uploaded package again. https://mentors.debian.net/debian/pool/main/g/growl-for-linux/growl-for-linux_0.8.4-1.dsc > lets review: > > 1) I really don't like a 2k lines long changelog for an initial inclusion. > most of the lines are "backport to dist foo" > > I would just delete them, keeping a public thank to the original maintainer > in an entry. > (or delete many of them, keeping only significative changes) I deleted them and added notes about original maintainer for simplicity. > 2) rules: > what I *really* don't like is: > "sed -i -e 's/-fPIE//g' plugins/Makefile" > > please not, fix autoreconf, not patch autogenerated makefiles. > > export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-pie should do the trick. Applied above, then enabled pie explicitly for gol again to make package in good shape. > BTW Ubuntu and maybe Debian in the future, will have gcc built with default pie, > so I guess you need to have an explicit -fno-pie injected, because it needs to be > forcibly disabled here, see bug #823869 I'll apply patch when actually it is needed. > I you can remove the lintian overrides, and the makeshlibs override > (I prefer a lintian warning here, but you are free to leave them) Removed it from the rule, and marked as a harmless lintian warning > 3) control file: > "autotools-dev" <-- is it needed? No. I removed it. > also please check if dh-autoreconf is needed or not No. It didn't needed. > 4) you might want to add some upstream metadata > https://wiki.debian.org/UpstreamMetadata > Added upstream/metadata file.
Attachment:
pgplQX1qVBrXM.pgp
Description: PGP signature