[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826661: RFS: groonga/6.0.4-1



control: owner -1 !

control: tags -1 moreinfo

Hi


>I am looking for a sponsor for my package "groonga"



Hi, I did a debdiff between them, and I see some changes that might be ABI breaking the library:

-GRN_API grn_rc grn_timeval_now(grn_ctx *ctx, grn_timeval *tv);
-GRN_API grn_rc grn_timeval2str(grn_ctx *ctx, grn_timeval *tv, char *buf, size_t buf_size);
-struct tm *grn_timeval2tm(grn_ctx *ctx, grn_timeval *tv, struct tm *tm_buffer);
-grn_rc grn_str2timeval(const char *str, uint32_t str_len, grn_timeval *tv);


removing symbols might be an ABI break

also adding a field to a struct
+  grn_bool is_dirty;

(not always)

as well as adding them in the middle of a struct
-  uint32_t reserved[1003];
+  uint32_t n_dirty_opens;
+  uint32_t reserved[1002];
grn_pat_delinfo delinfos[GRN_PAT_NDELINFOS];
grn_id garbages[GRN_PAT_MAX_KEY_SIZE + 1];


also, before sponsoring please consider adding something to copyrights for the next upload.

e.g.

+ Copyright (C) 2016 Kouhei Sutou <kou@clear-code.com>

(this isn't a blocker because license is fine)

so, please answer wrt ABI/API breakage.

(there seem to be only one reverse dependency

groonga-normalizer-mysql)

Gianfranco


Reply to: