[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826337: RFS: opengrm-ngram/1.3.0-1 -- opengrm n-gram library



* Giulio Paci <giuliopaci@gmail.com>, 2016-06-04, 18:42:
git clone git://anonscm.debian.org/collab-maint/opengrm-ngram.git

Let me see:

+  * Drop 1001_fix_compilation_issues.patch.
+    No more needed.

I'm not a native speaker of English, but shouldn't it be s/more/longer/?

+Maximum number of ngrams to leave in model after pruning.Value less than zero means no target number, just use theta.

Space is missing between "pruning." and "Value".

There's an unholy mixture of tabs and spaces in update-man.sh: the line you added is indented by 8 spaces, whereas the surrounding lines are indented by tabs.

There's a similar mixture of tabs and spaces in the definition of BACKUP in debian/rules.

In #687563, I asked you to talk to upstream about insecure use of /tmp in the test suite. Did anything happen about this?

Now that OpenFST is in unstable, should we upload this package to unstable too?

--
Jakub Wilk


Reply to: