[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#820704: Bug#820705: RFS: subuser/0.5.6-3 [ITP]



control: owner -1 !
control: tags -1 moreinfo

Hi,

lets see:


"export PYTHON=`which python3`" what?


http://debomatic-amd64.debian.net/distribution#unstable/subuser/0.5.6-1/lintian
please fix the first lintian warning.

"Depends: ${misc:Depends}, ${python3:Depends}, python3-setuptools, git, docker.io"

why setuptools?

d/clean: is it useful?

d/copyright: "LGPL" <-- please add the version.

missing licenses:
./docs/_themes/sphinx_rtd_theme/static/css/theme.css: *  License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License)
./docs/_themes/sphinx_rtd_theme/search.html:    :license: BSD, see LICENSE for details.
./docs/_themes/sphinx_rtd_theme/layout_old.html:    :license: BSD, see LICENSE for details.



apt-get install -t experimental check-all-the-things:
$ codespell --quiet-level=3


$ pep8 --ignore W191 .


$ pyflakes3 .

$ find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \) -exec shellcheck {} +

$ suspicious-source

$ grep -r '/tmp/' .


Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata


other stuff LGTM

G.


Reply to: