[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826063: RFS: libu2f-host/1.0.0-2 [NMU] [RC] -- U2F host communication library



control: tags -1 moreinfo

On Thu, Jun 02, 2016 at 01:31:02AM +0200, Nicolas Braud-Santoni wrote:
> Package: sponsorship-requests
> Severity: important
> 
> Dear mentors,
> 
> I am looking for a sponsor for my upload for the libu2f-host package.
> It fixes the following RC bug:
>   #820686: FTBFS - missing build-dep libglib2.0-dev
> 
> The package's maintainer team, the Debian Authentication Maintainers, has
>   not commented on the bug since it was opened, 2 months ago.
> 
> 
> The dsc and build artifacts can be found in
>   https://nicolas.braud-santoni.eu/tmp/deb/

The dsc there doesn't unpack -- filenames nor checksums don't match.

> They were produced, using pdebuild(1), from the source in
>   https://github.com/nbraud/libu2f-host-dpkg/tree/bug-820686
>   (signed commit 4e6802ca12362e415ee45fcab64f38a601b02420)
> 
> This changed has been submitted back to the packaging repo as a pull request:
>   https://github.com/Yubico/libu2f-host-dpkg/pull/1
> 
> It ignores the commits that got added since the last version that was published
>   in the archive (esp. the merging of a new upstream version).

Only one of four commits atop of debian/1.0.0-1 looks relevant:
40d4511 has the following changes:
+ updated build-dependencies (ie, the meat of the NMU)
+ standards version bump
+ a changelog entry (with an error: you need # after "Closes: " before the
  number)

e12e613 adds an UNRELEASED changelog entry and some gbp junk.
3d0722a tries to invent a way of generating "orig" tarballs.
+ this is bad as those don't match upstream.  Besides details like losing
  timestamps or degrading xz to gz, you really should use what upstream
  provides, unless this is impossible because of git-only releases or a
  need to repack.
+ not using upstream tarballs ie especially bad as these are signed
4e6802c tries to ignore changes in a generated file instead of properly
  cleaning it (deletion would suffice)

On the other hand, something in clean-up after build does happen to break
the package.  If you try to package the source from a fresh repository, it
succeeds.  After a build, newly repacked source won't build anymore:

/bin/bash /home/kilobyte/tmp/pkg/libu2f-host-dpkg/build-aux/missing help2man \
	--output=u2f-host.1 ./u2f-host \
	--name="Yubico Universal 2nd Factor (U2F) Host Tool" \
	--no-info
help2man: can't get `--help' info from ./u2f-host
Try `--no-discard-stderr' if option outputs to stderr
WARNING: 'help2man' is missing on your system.
         You should only need it if you modified a dependency of a man page.
         You may want to install the GNU Help2man package:
         <http://www.gnu.org/software/help2man/>
Makefile:952: recipe for target 'u2f-host.1' failed
make[4]: *** [u2f-host.1] Error 127


Meow!
-- 
An imaginary friend squared is a real enemy.


Reply to: