Bug#825531: RFS: libcork/0.15.0+ds-1 [ITP]
Dear G,
Thank you for reviewing my package!
Changes are push to branch pkg2 of github: https://github.com/rogers0/libcork
And package on mentors also get updated.
On Wed, Jun 1, 2016 at 4:48 AM, Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
>
> Hi, I did a quick look and the package looks great!
Though I'm maintaining a few package through RFA, this is the real
first time to create my scratch.
I'm relieved you find it not bad.
> 1) W: libcork source: debian-watch-file-should-mangle-version line 7
It's false positive.
Found it's already in BTS, so I just appended my record there:
https://bugs.debian.org/505857#40
> 2) lrwxrwxrwx root/root 0 2016-05-31 21:37 ./usr/lib/libcork.so.15 -> libcork.so.16.0.1
The SONAME (15) and version (16.0.1) are given by upstream.
I guess it's also for legacy reason, to be compatible with other system.
So better not change by ourselves. I'll try to contact upstream, but
it seems they're not very active, it may take time to let them change
SONAME.
> some other stuff I would appreciate to see fixed:
>
> 3) consider a split of the html stuff into a doc package, this way packages depending on the -dev will grab a package
> with a lower size
> 4)stop shipping the .a library (not requested BTW, I just avoid them when possible)
Thanks for your advice.
Fixed now.
> 5) multiarch.
> https://wiki.debian.org/Multiarch/Implementation
I'm not sure whether multiarch helps for this library.
Since only shadowsocks-libev (in RFS now) will depend on it so far.
I'll do it when the need comes.
> 6) is testsuite run or not?
Yes, it runs after compiling.
I tested OK on amd64 and armel, by both common gbp and gbp with pbuilder.
> 7) sed -i s%https://cdn.mathjax.org/mathjax/latest/MathJax.js%file:///usr/share/javascript/mathjax/MathJax.js% build/docs/old/html/*.html
>
> this seems hacky, are you sure there isn't a better way to handle this?
> (one day the path for the external might change, and the sed will become useless)
Yes, kinda hacky.
But original CDN url also may broken someday.
User should read HTML without those JS anyway (I didn't test this).
And the purpose to do this way is to avoid one lintian complaint.
Hope you feel the updated package more comfortable.
Thanks again.
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1
Reply to: