control: tag -1 +moreinfo control: owner -1 ! Dear Emily, I can't sponsor the package, but here's a review that I hope is helpful to you. - you can bump the standards version to 3.9.8 - try bumping the debhelper compat level to 9 (or even 10) and see if it works - the Debian changelog should contain exactly one entry, since the package has not yet been uploaded to Debian - that entry should close your ITP bug (include the string "Closes: #XXXXXX") - you should probably list yourself in addition to Jan Wagner as holding copyright on debian/* - I'm not sure about this, but I think the Source: line in d/copyright should point to the project homepage, not a tarball download (likely to be more useful to someone reading it) - you should include a rule in d/rules to generate maldet.1 with help2man, and explain how to use it in README.source. For an example, see the rules file of the ocrmypdf package. It's okay to include the generated, maldet.1 in the source package since it can't be generated before you've built maldetect. But it should be obvious how someone else can regenerate it. - I'm not sure you actually need the override_dh_md5sums. Are you just attempting to set the mtime of every file to the builddate, or are you doing more than that? I think that dh_strip_nondeterminism will do that for you (even if the version currently in Debian Sid won't, the reproducible builds team toolchain gets basic stuff like this right) - please use a secure https url in Vcs-Git in d/control - you might consider using "GNU/Linux" instead of "Linux" in the package description, since Debian identifies itself as a "GNU/Linux" distribution - you should add descriptions to each patch that currently lacks one. For example, why are you removing shebangs? It should be clear why the patch is needed. - also add a Forwarded: line to your patches. For Debian-specific patches that upstream will never want to merge, just add "Forwarded: not-needed". Otherwise, forward the patch upstream and provide a link to the mailing list post, pull request etc. - you need to add a dependency on procps. The package currently fails piuparts testing because of this: ,---- | 3m35.6s DEBUG: Starting command: ['schroot', '--preserve-environment', | '--run-session', '--chroot', | 'session:unstable-i386-piuparts-498528de-27a7-11e6-b379-90e6ba5fdd9b-piuparts', | '--directory', '/', '-u', 'root', '--', 'eatmydata', | '/etc/cron.daily/maldetect'] | 13m23.6s DUMP: | /etc/cron.daily/maldetect: line 43: ps: command not found | 13m23.6s ERROR: Command failed (status=127): ['schroot', | '--preserve-environment', '--run-session', '--chroot', | 'session:unstable-i386-piuparts-498528de-27a7-11e6-b379-90e6ba5fdd9b-piuparts', | '--directory', '/', '-u', 'root', '--', 'eatmydata', | '/etc/cron.daily/maldetect'] | /etc/cron.daily/maldetect: line 43: ps: command not found `---- (I haven't actually tried to install and use the package yet.) -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature