[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825302: RFS: usbguard/0.4-2 [ITP]



On Sat, May 28, 2016 at 6:43 PM, Muri Nicanor wrote:

> oke, i've fixed that to my best knowlegde.
> i've created a list with files that lack any license and will file a bug
> upstream about that.

Great, thanks.

> oke, so:
> i've filed #825620 (ITP: quex), #825623 (ITP: json), #825625 (ITP: usbmon)

Excellent.

> i've tried to exclude the folders using Files-Exclude, but that didn't
> seem to work. i'm now deleting them in override_dh_auto_configure and
> override_dh_auto_clean.
> as soon as all the dependencies are packaged, i'll file a bug report
> about removing the bundled code.

The only advantage of Files-Excluded (did you forget the d?) is that
you don't need to document the embedded code copies in
debian/copyright and that they don't waste space on Debian mirrors. If
you've already documented them and are removing them in debian/rules,
it isn't worth diverging from upstream by using Files-Excluded.

> i don't get the meaning of that last sentence, could you elaborate?

The .roff files in the source package are generated files that were
built from Markdown files using ronnjs and unfortunately those
Markdown files are not present in the source package (but are in
upstream git), so the usbguard docs cannot be modified and rebuilt
from source on Debian. Personally I would get the .roff files removed
from upstream git/tarballs and request the docs always be built from
the Markdown source at build time. Upstream uses ronnjs for building,
which you could package but there is ruby-ronn in Debian which might
also work, you would have to compare the generated .roff files and
talk to upstream though to see if that would be appropriate.

https://github.com/dkopecek/usbguard/tree/master/doc
https://github.com/kapouer/ronnjs
https://rtomayko.github.io/ronn/

$ head -n2 doc/*
==> doc/usbguard-daemon.conf.roff <==
.\" Generated with Ronnjs 0.4.0
.\" http://github.com/kapouer/ronnjs

==> doc/usbguard-daemon.roff <==
.\" Generated with Ronnjs 0.4.0
.\" http://github.com/kapouer/ronnjs

==> doc/usbguard.roff <==
.\" Generated with Ronnjs 0.4.0
.\" http://github.com/kapouer/ronnjs

==> doc/usbguard-rules.conf.roff <==
.\" Generated with Ronnjs 0.4.0
.\" http://github.com/kapouer/ronnjs

> what do you mean by 'how systemd does it'?

Documentation in /usr/share/man or /usr/share/doc, default settings in
/usr/share/pkg, distro overrides in /usr/share/pkg, sysadmin settings
in /etc and per-user settings in ~/.config, with easily installed
overrides for every location since each config file has an associated
.d directory.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


Reply to: