[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821270: Review of git version



Updated:
* Reworded the description.
* There is no override anymore, although this is not yet perfect. The
package *generates* files using various tools. The Debian policy
requires the inclusion of source files. Thus this package can't be like
a typical simple add-on package.
* Corrected the changelog.

On 26/05/16 07:57, Sean Whitton wrote:
> Hello,
> 
> Thank you for getting this project onto alioth.[1] Here's my review of
> the version I found there:
> 
> 1. Have you considered reworking the long description as I suggested
>    previously?
> 
> 2. Are you sure you aren't willing to rework the organisation of the
>    project to avoid the override in d/rules?  I don't think that's a
>    reason not to upload the package, but it would be a nice improvement.
> 
> 3. You should have exactly one debian/changelog entry, saying something
>    like "Initial release (Closes: #821210)."  You shouldn't have
>    changelog entries tracking changes made in response to comments in
>    this RFS thread since those were not uploaded to Debian.
> 
> [1] https://anonscm.debian.org/git/pkg-mozext/iceweasel-branding.git
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: