[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#824900: RFS: iroffer-dinoex/3.30-1 [ITP]



On Sat, May 21, 2016 at 04:23:51PM -0700, optix2000@teitoku.net wrote:
> > > > d/rules:
> > > > - why -D_FORTIFY_SOURCE=1? Such things should be documented
> > > 
> > > For security reasons, as this is an internet accessible daemon that
> > > accepts user input. 
> > What I've meant was "you replaced stronger default flag with a weaker
> > one". As you know about dpkg-buildflags you should know that the 'fortify'
> > option is enabled by default and that it adds -D_FORTIFY_SOURCE=2.
> 
> Didn't know that D_FORTIFY_SOURCE=2 was the default. 
See dpkg-buildflags(1)

> Until it's fixed upstream what is the "correct" way of getting it to compile
> with -D_FORTIFY_SOURCE?
To patch the upstream build system to properly use CPPFLAGS from the environment.

> > > > - you can probably replace override_dh_auto_clean with debian/clean
> > > 
> > > I can't seem to find any documentation regarding debian/clean in the
> > > maint-guide [https://www.debian.org/doc/manuals/maint-guide/dother.en.html]
> > > How is debian/clean supposed to be used?
> > man dh_clean
> > To remove files not removed by dh_auto_clean.
> 
> How handy. I've fixed the build to use debian/clean.
> How do I get that documented in the maint-guide?
By filing a bug against the maint-guide package.

> What you described is what I intended the functionality to be. iroffer-dinoex
> should be able to be installed _over_ iroffer (apt will remove the old package
> automatically)
>   % sudo dpkg -i iroffer-dinoex_3.30-1_amd64.deb
This not apt but dpkg. I think you'll need to make a local repo to test it
with apt.

-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: