Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Gianfranco Costamagna <locutusofborg@debian.org>]

control: tags -1 moreinfo

Hi Eric, some questions on the changes:
1) why do you need both autotools-dev and autoreconf?

2) did you get an ack from maintainers to add yourself as uploader


3) +Replaces: gnustep-common (<< 2.6.8-1)

this is something I don't understand.

also, the control.in file removal is not documented I guess

maybe Aron (ccd), being the latest sponsor might give you an additional review and sponsor the package

thanks for the really nice work! I did a test build and the build logs looks good to be, as well as the built
binaries (however I didn't install them).

thanks

Gianfranco



Il Domenica 15 Maggio 2016 3:39, Eric Heintzmann <heintzmann.eric@free.fr> ha scritto:



Le 15/05/2016 03:26, Adam Borowski a écrit :
> On Sun, May 15, 2016 at 03:04:37AM +0200, Eric Heintzmann wrote:
>> Le 15/05/2016 02:46, Adam Borowski a écrit :
>>> On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
>>>>   I am looking for a sponsor for my package "gnustep-make"
>>>>
>>>>  * Package name    : gnustep-make
>>>>    Version         : 2.6.8-1
>>>>
>>>>     dget -x https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc
>>> As there's LOADS of packaging changes, could you please push them to a VCS? 
>>> That'd make reviewing greatly easier.  From the new changelog I assume you
>>> used git, I just don't see anything new past 2.6.6-3 on any branches on
>>> pkg-gnustep/gnustep-make.git.
>> Sorry, but I've not used git nor any VCS because I work all alone
>> since I am the last active member of the Debian GNUstep maintainers.
>> If I had knew that make reviewing easier, I would have used Git.
>> If you want I can push my changes on pkg-gnustep/gnustep-make.git
>> but there will be only one big commit.
>> Sorry, I ve done a mistake how can I repair it ?
> Oif.  I guess trying to split this big commit would be far more work than
> just reviewing it the hard way, so there's nothing that can be done here.
> That's unfortunate as it raises the difficulty of review considerably.
>
> As gnustep-make is a complex package I'm not familiar with, I'm afraid
> I'll leave it to someone with more time and experience.
>
I think I can split this big commit in multiple commits, one for each file.
If needed I will do it.

Thanks