control: tag -1 moreinfo
control: owner -1 !
On Wed, Mar 30, 2016 at 11:47:40PM -0700, Tom Lee wrote:
> I am looking for a sponsor for the "spin" package:
o/
> dget -x http://mentors.debian.net/debian/pool/main/s/spin/spin_6.4.5-1.dsc
Actually, I'm going to use the git repository, as there is a nice
Vcs-Git field.
Based on what I found on that repo:
* d/control:
+ use https in Vcs-Git
+ Standards-Version is 3.9.8 nowadays, please check it out
+ as Paul said, please drop the -dbg package
* d/docs:
+ I'd like to have it renamed to d/spin.docs for consistency with the
other files
* d/outfile:
+ ???
* d/patches/01_makefile_fixes.patch:
+ Probably use += instead of ?= in the first CFLAGS?
+ I'd rather use install(1) instead of cp(1)
+ Really forward at least the DESTDIR/INSTALL change
* d/patches/02_manpage_fixes.patch:
+ what's blocking you from forwarding this patch?
* d/rules:
+ get rid of all those useless comments
+ DPKG_EXPORT_BUILDFLAGS and the inclusion of buildflags.mk is
useless, please read debhelper(7)
+ trailing whitespace at line 22
+ what's wrong with using --sourcedirectory on the dh(1) call instead
of overriding everything like that?
+ I'd avoid that "INSTALL=install -D" by patching correctly the
makefile to default INSTALL on install(1) instead of cp(1) (as I
said above)
* d/spin-docs.docs:
+ there is no package named like this, so what's the point of this
file?
+ also, README.source is not supposed to be shipped in any binary
package
All this said, I did not try building it, nor checking for
copyright/licensing stuff.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature