[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823187: RFS: icdiff/1.7.3-1



Hi Paul,

>> I see. Unfortunately the copy of this file that upstream ships does
>> not include a license; however a newer version does.
>> I have excluded the old version from 1.7.6 using d/copyright's Files-
>> Excluded, and then patched the code to use the newer version I
>> distribute myself as part of the package. That is, until upstream
>> accepts my PR that updates these test files directly:
>> https://github.com/jeffkaufman/icdiff/pull/70
> 
> Looks like upstream has accepted your PR and released 1.8.1.

Yes, unfortunately that introduced a new issue with an unrelated PR that
was merged in the meantime as well. I'm on it (https://github.com/jeffkaufman/icdiff/issues/68).

>> Sure, I guess this is something to be done after the package entered unstable?
> 
> It can be done before or after that, there is syntax for ITPs.

OK, will do that ASAP.

>> AFAICS icdiff is currently compatible with both Python 2 and Python 3.
> 
> Excellent. In case upstream doesn't want to switch to using Python 3 in
> the script, I would recommend the Debian version do that.

OK, I have already done that in my version here and will push it with the next upload.

>> Please let me know what you think.
> 
> How about packaging 1.8.1 and then I'll upload it?

1.8.1 currently FTBFS due to a setuptools-related change that was also
introduced in this version. Currently discussing this with upstream to
sort it out. I will ping the list again if there has been progress.

Thanks for taking a look,
Sascha

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


Reply to: