Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP]

[Gianfranco Costamagna <locutusofborg@debian.org>]

Hi,

>set(CFLAGS ...) which should be replaced by set(CFLAGS $(CFLAGS) ...)
>
>An upstream classic unfortunately.


as upstream I did this once, and the side effect was something weird.

when you run multiple times cmake .. the cflags gets appended multiple times, so you might
end up in a really weird CMakeCache.txt and with really long build lines.

I'm not sure which way is the best one, but cmake should provide something different from CFLAGS.

e.g.
CMAKE_C_FLAGS
CMAKE_C_FLAGS_RELEASE
CMAKE_C_FLAGS_DEBUG
CMAKE_EXE_LINKER_FLAGS
CMAKE_MODULE_LINKER_FLAGS

and so on.
that way they will be appended to current CFLAGS without having to override them manually.

(thanks again for your nice reviews!)

g.