Bug#823140: RFS: caffe/1.0.0~rc3-1 -- a deep learning framework [ITP]
control: owner -1 !
control: tags -1 moreinfo
Hi Ghislain, thanks for the good review!
I remember I looked at this package a while ago, so, if you (lumin) can fix what Ghislain
pointed out, I'll be happy to do a new reivew and hopefully sponsor :)
cheers,
G.
Il Lunedì 2 Maggio 2016 15:13, Ghislain Vaillant <ghisvail@gmail.com> ha scritto:
On 01/05/16 12:44, lumin wrote:
> Package: sponsorship-requests
> Severity: wishlist
> X-Debbugs-CC: aron@debian.org, debian@danielstender.com, debian@onerussian.com, debian-devel@lists.debian.org, debian-science@lists.debian.org
>
> Dear mentors,
>
> I am looking for a sponsor for my package "caffe"
>
> * Package name : caffe
> Version : 1.0.0~rc3-1
> Upstream Author : Berkeley Vision and Learning Center
> * URL : caffe.berkeleyvision.org
> * License : BSD-2-Clause
> Section : science
>
> It builds those binary packages:
>
> caffe-cpu - Fast, open framework for Deep Learning (CPU_ONLY)
> caffe-cuda - Fast, open framework for Deep Learning (CUDA)
> libcaffe-cpu-dev - development files for Caffe (CPU_ONLY)
> libcaffe-cpu1 - library of Caffe, a deep learning framework (CPU_ONLY)
> libcaffe-cuda-dev - development files for Caffe (CUDA)
> libcaffe-cuda1 - library of Caffe, a deep leanring framework (CUDA)
> python-caffe-cpu - Python2 interface of Caffe (CPU_ONLY)
> python-caffe-cuda - Python2 interface of Caffe (CUDA)
>
> To access further information about this package, please visit the following URL:
>
> https://mentors.debian.net/package/caffe
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/contrib/c/caffe/caffe_1.0.0~rc3-1.dsc
>
> Debomatic-amd64 build log can be obtained at
>
> http://debomatic-amd64.debian.net/distribution#experimental/caffe/1.0.0~rc3-1/buildlog
> Note, the source uploaded to debomatic-amd64 is different to the one
> at mentors -- the time stamp in d/changelog differs, the only difference.
>
> Changes since the last upload:
>
> caffe (1.0.0~rc3-1) experimental; urgency=low
>
> * Initial release. (Closes: #788539)
> * Fix spelling error in src/caffe/layers/memory_data_layer.cpp.
>
> Thanks :-)
>
A few remarks:
- d/changelog: should only contain the entry closing the initial release
bug.
- d/control: Build-Depends on libboost-all-dev. Do you really need to
pull the complete Boost stack for the build? Quick look I have had:
"find_package(Boost 1.46 REQUIRED COMPONENTS system thread filesystem)"
So you should only require libboost-{filesystem,system,thread}-dev.
- d/control: Build-Depends on nvidia-cuda-toolkit which automatically
pulls nvidia-cuda-dev, so no need to specify nvidia-cuda-dev.
- d/*.install.in: no multi-arch install paths? why?
- d/libcaffe-dev.install.in: what is the purpose of the additional
libproto.a binary?
- d/rules + d/*.in: IMO, sounds like a very convoluted way of running 2
separate builds (one for CPU one for CUDA) and moving the files in the
right places. Another possibility could have been to have caffe-cpu and
caffe-cuda as separate source packages, one in main and one in contrib.
For each of them, the packaging would have been much more simple to
maintain I suppose.
- lintian (from d-o-m):
I: caffe source: quilt-patch-missing-description fix-spelling-error
Might want to fix this if not done already. Also please mention whether
the patch has been forwarded upstream.
I: libcaffe-cpu-dev: unstripped-static-library
usr/lib/caffe/libproto.a(caffe.pb.cc.o)
Again not sure what this libproto.a is doing here.
I: libcaffe-cpu1: hardening-no-fortify-functions
usr/lib/libcaffe.so.1.0.0-rc3
Are you using hardening in d/rules? If so, then the injected flags
might be shadowed by the build system. Consider fixing this.
Good luck,
Ghis
Reply to: