Control: owner -1 !
Am 26.04.2016 um 12:10 schrieb Shlomi Fish:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "freecell-solver"
Hi Shlomi,
First of all thank you for updating freecell-solver. Your effort is much
appreciated. I intend to sponsor your package and to upload it to the
DELAYED/10 queue, should there be no reaction from the maintainer within
the next couple of days.
In general the changes look good to me but there is one serious issue
and a couple of smaller, non-intrusive ones which are already present in
the current package. While we are at it we should fix them.
You can use Lintian to detect them and by creating the lintianrc file in
~/.config/lintian/lintianrc
with the following content:
info=yes
display-info=yes
display-experimental=yes
pedantic=yes
show-overrides=yes
color=auto
verbose=yes
or by looking at this page
http://mentors.debian.net/package/freecell-solver
The serious one is the incomplete copyright file:
The copyright file states that all code is in the public domain. This is
not correct. There are source files with different license headers, e.g
Your own code is licensed under the MIT/Expat license.
board_gen/make_pysol_freecell_board.py (GPL-2+)
patsolve-shlomif/patsolve/ga/mt19937.c (LGPL)
Copyright (c) 2002 Tom Holroyd (Expat/MIT License)
Copyright (C) 2014 insane coder (http://insanecoding.blogspot.com/,
http://asprintf.insanecoding.org/)
+
+Permission to use, copy, modify, and distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Please update debian/copyright accordingly.
Optional: You could transform the file to copyright format 1.0.
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Other issues:
Only debian/control.in should be modified because the package uses
DEB_AUTO_UPDATE_DEBIAN_CONTROL from CDBS.
Dependency on debhelper should be debhelper (>= 9). Please remove the
duplicate entry debhelper (>= 7) in debian/control and update
debian/control.in accordingly.
debian/control.in: Please update the Vcs-fields to use Debian's
canonical URLs.
Vcs-Browser:
https://anonscm.debian.org/cgit/collab-maint/freecell-solver.git
Vcs-Git: https://anonscm.debian.org/git/collab-maint/freecell-solver.git
Please install the upstream changelog (NEWS.txt) in debian/rules with
DEB_INSTALL_CHANGELOGS_ALL := NEWS.txt
Since you are upstream for freecell-solver please consider to fix the
following minor issues:
There is a typo in main.c: explictly => explicitly
Please consider to write a man page for freecell-solver-config.
There is a spelling error in fc-solve.6 allows to => allows one to.
You could cryptographically sign your package, so that debian/watch can
verify its integrity.
https://lintian.debian.org/tags/debian-watch-may-check-gpg-signature.html
You might want to run check-all-the-things on your code. It executes
different checkers which may help you to improve freecell-solver.
e.g.
pep8 --ignore W191 . (Improvement suggestions how to style your code
according to pep8)
find -type f -iname '*.sh' -exec checkbashisms {} +
There are multiple *.sh files that don't seem to have a #! interpreter line.
There are more typos which can be found with
codespell --quiet-level=3
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find
or open any of the paths given.'
[fc_pro_range_solver.c:429]: (error) Memory leak: binary_output.file
[state.h:32]: (error) Invalid number of character '{' when these macros
are defined: 'COMPACT_STATES'.
[state.h:32]: (error) Invalid number of character '{' when these macros
are defined: 'DEBUG_STATES'.
[state.h:32]: (error) Invalid number of character '{' when these macros
are defined: 'INDIRECT_STACK_STATES'.
Regards,
Markus
Attachment:
signature.asc
Description: OpenPGP digital signature