Bug#822728: RFS: libtcod/1.6.0~pre1+dfsg-1 [ITP] -- graphics and utility library for roguelike developers
Hi, some general notes:
Adam, do you plan to sponsor the package? in this case can I set you as owner? :)
Fabian, why are you trying to package an upstream snapshot?
(not asking to package 1.5.1, I'm just wondering about why a new library should
eventually enter Debian in a snapshot form)
cheers,
G.
Il Mercoledì 27 Aprile 2016 5:30, Adam Borowski <kilobyte@angband.pl> ha scritto:
On Tue, Apr 26, 2016 at 10:22:32PM +0200, Fabian Wolff wrote:
> * Package name : libtcod
I'm afraid that it builds only on 64-bit architectures (I tried amd64 and
arm64), on 32-bit ones (x32 armhf i386) it fails with:
dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libtcod0/DEBIAN/symbols doesn't match completely debian/libtcod0.symbols
--- debian/libtcod0.symbols (libtcod0_1.6.0~pre1+dfsg-1_x32)
+++ dpkg-gensymbolsZSmCIg 2016-04-27 02:14:30.890101840 +0000
@@ -1511,7 +1511,7 @@
(c++)"TCODSystem::newMutex()@Base" 1.6.0~pre1
(c++)"TCODSystem::newSemaphore(int)@Base" 1.6.0~pre1
(c++)"TCODSystem::newThread(int (*)(void*), void*)@Base" 1.6.0~pre1
- (c++)"TCODSystem::readFile(char const*, unsigned char**, unsigned long*)@Base" 1.6.0~pre1
+#MISSING: 1.6.0~pre1+dfsg-1# (c++)"TCODSystem::readFile(char const*, unsigned char**, unsigned long*)@Base" 1.6.0~pre1
(c++)"TCODSystem::registerSDLRenderer(ITCODSDLRenderer*)@Base" 1.6.0~pre1
(c++)"TCODSystem::saveScreenshot(char const*)@Base" 1.6.0~pre1
(c++)"TCODSystem::setClipboard(char const*)@Base" 1.6.0~pre1
@@ -1560,6 +1560,7 @@
(c++)"TCODZip::~TCODZip()@Base" 1.6.0~pre1
TCOD_CRenderer@Base 1.6.0~pre1
(c++)"TCOD_path_func(int, int, int, int, void*)@Base" 1.6.0~pre1
+ _ZN10TCODSystem8readFileEPKcPPhPj@Base 1.6.0~pre1+dfsg-1
end_struct@Base 1.6.0~pre1
error@Base 1.6.0~pre1
internalListener@Base 1.6.0~pre1
So you need to adjust the symbols file.
Also, it'd be nice if you added --parallel to the dh call, it massively
speeds up builds[1] on any non-museal machine. It's default in upcoming
debhelper 10.
Meow!
[1]. To actually make --parallel work, the person running the build needs to
set: export DEB_BUILD_OPTIONS=parallel=`grep ^processor /proc/cpuinfo|wc -l`
but this is outside the packaging.
--
A tit a day keeps the vet away.
Reply to: