Re: Seeking Sponsors for my package - capitan
control: owner -1 !
control: tags -1 moreinfo
Hi, please fix something (all) of what Paul pointed,
open an RFS bug and I'll have another look
BTW please please depend on libpng-dev instead of libpng12-dev
thanks.
G.
Il Lunedì 28 Marzo 2016 9:28, Paul Wise <pabs@debian.org> ha scritto:
On Mon, Mar 28, 2016 at 2:17 PM, Carlos Donizete Froes wrote:
> I'm looking for a sponsor my game package capitan [Capitan Sevilla -
> Remake]
...
> Awaiting reviews, tips, advice or approval of package.
I don't intend to sponsor this but here is some advice:
You may want to join the Debian games team:
https://wiki.debian.org/Games/Team
If you are in contact with upstream, please give them these links:
https://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream/
Please forward the patches upstream if you haven't already. If you
have, please mark them as forwarded according to DEP-3.
http://dep.debian.net/deps/dep3/
Please forward the manual page upstream if you haven't already. If you
have, please add a comment indicating that.
It should not be necessary to remove an upstream debian/ directory
with dpkg-source v3 source packages since dpkg-source automatically
removes the upstream debian/ directory after unpacking the upstream
tarball.
You might want to ask upstream to supply OpenPGP signatures of their
releases and look at the OpenPGP best practices:
https://wiki.debian.org/debian/watch#Cryptographic_signature_verification
https://help.riseup.net/en/security/message-security/openpgp/best-practices
Please add a Comment field to debian/copyright about why each of the
files/dirs in Files-Excluded are there.
Please ask upstream to make everything in Files-Excluded DFSG-free so
we don't need to remove it.
I would suggest wrapping and sorting the Debian files to make diffs
easier to read. This is my favourite command for that:
wrap-and-sort --short-indent --wrap-always --sort-binary-packages
--trailing-comma --verbose
Everything in Debian main is "open-source" so it isn't necessary to
mention that in the description.
A typo in the description: replace "how did it get the" with "how did
he get the". You may want to get the package description reviewed by
folks on the debian-l10n-english mailing list.
https://lists.debian.org/debian-l10n-english/
The code in the dependencies/ directory and needs to be removed from
upstream and packaged separately:
https://wiki.debian.org/EmbeddedCodeCopies
loadpng is also an embedded code copy that should be removed from
upstream but it is already packaged:
./src/loadpng.cpp
./src/include/loadpng.h
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
I noticed the window icon under GNOME is an allegator instead of Captain S.
Automatic checks:
lintian
P: capitan source: debian-watch-may-check-gpg-signature
P: capitan: no-upstream-changelog
check-all-the-things
$ cme check dpkg
cme: using Dpkg model
loading data
Warning in 'patches:"dependencies.patch" Synopsis' value '': Empty
synopsis (this can be fixed with 'cme fix' command)
Configuration item 'patches:"dependencies.patch" Author:0' has a wrong value:
"uniline" value must not contain embedded newlines (\n)
$ codespell --quiet-level=3
./src/messages.cpp:38: caracter ==> character
./src/hardware.cpp:110: comando ==> commando
./src/menu.cpp:418: Caracter ==> Character
./src/menu.cpp:420: Caracter ==> Character
./src/menu.cpp:421: Caracter ==> Character
./src/menu.cpp:422: Caracter ==> Character
./src/menu.cpp:426: Caracter ==> Character
./src/actormanager.cpp:413: momento ==> memento
./docs/readme.linux:7: dependant ==> dependent
./debian/capitan.6:12: firts ==> flirts, first
./debian/capitan.6:222: appereance ==> appearance
$ cppcheck -j1 --quiet -f .
[src/hardware.cpp:1690]: (error) Undefined behavior: Variable 'title'
is used as parameter and destination in s[n]printf().
[src/hardware.cpp:1692]: (error) Undefined behavior: Variable 'title'
is used as parameter and destination in s[n]printf().
[src/hardware.cpp:1693]: (error) Undefined behavior: Variable 'title'
is used as parameter and destination in s[n]printf().
[src/partida.cpp:393]: (error) Uninitialized variable: Ciclos
$ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
./extra/capitan.desktop: error: value "1.0.3" for key "Version" in
group "Desktop Entry" is not a known version
./extra/capitan.desktop: error: (will be fatal in the future): value
"capitan.png" for key "Icon" in group "Desktop Entry" is an icon name
with an extension, but there should be no extension as described in
the Icon Theme Specification if the value is not an absolute path
./extra/capitan.desktop: warning: value "Application;Game;" for key
"Categories" in group "Desktop Entry" contains a deprecated value
"Application"
./extra/capitan.desktop: error: required key "Type" in group "Desktop
Entry" is not present
$ find \( -name .git -o -name .svn -o -name .bzr -o -name CVS -o -name
.hg -o -name _darcs -o -name _FOSSIL_ -o -name .sgdrawer \) -prune -o
-empty -print
./include
./src/obj
$ flawfinder -Q -c .
<lots>
# check if these can be switched to https://
$ grep -rF http: .
./src/main.cpp: En caso contrario, consulte <http://www.gnu.org/licenses/>.
./src/main.cpp: along with this program. If not, see
<http://www.gnu.org/licenses/>.
./docs/license.txt: Copyright (C) 2007 Free Software Foundation, Inc.
<http://fsf.org/>
./docs/license.txt: along with this program. If not, see
<http://www.gnu.org/licenses/>.
./docs/license.txt:<http://www.gnu.org/licenses/>.
./docs/license.txt:<http://www.gnu.org/philosophy/why-not-lgpl.html>.
./docs/licencia.txt:Copyright (C) 2007 Free Software Foundation, Inc.
<http://fsf.org/>
./debian/watch:http://computeremuzone.com Capitan(.+).(?:zip|tar\.(?:bz2|gz|xz))
./debian/copyright:Source: http://computeremuzone.com/ficha.php?id=754&l=en
./debian/capitan.6:This game has been releasend under GPLv3 license.
Please, visit the following website for further info:
http://www.gnu.org/licenses/gpl-3.0.html
./debian/control:Homepage: http://computeremuzone.com/ficha.php?id=754&l=en
$ find -type f \( -iname '*.c' -o -iname '*.cc' -o -iname '*.cxx' -o
-iname '*.cpp' -o -iname '*.h' -o -iname '*.hh' -o -iname '*.hxx' -o
-iname '*.hpp' \) -exec include-what-you-use {} \;
<lots>
$ licensecheck --check=. --recursive --copyright . | grep -F 'GENERATED FILE'
./src/include/samples.h: *No copyright* GENERATED FILE
./src/include/music.h: *No copyright* GENERATED FILE
./src/include/bitmaps.h: *No copyright* GENERATED FILE
./src/include/sprites.h: *No copyright* GENERATED FILE
./src/include/sfx.h: *No copyright* GENERATED FILE
./src/menu.cpp: *No copyright* GENERATED FILE
# Users of binary packages do not need install instructions.
$ find -type f -iname '*README*' -a ! \( -iname README.md -o -iname
README.rst -o -iname README.install \) -exec grep --ignore-case
--fixed-strings --with-filename install {} +
./docs/readme.linux:install the Allegro library to play the game. It has no
./docs/readme.linux:on INSTALL file: Please, read it.
./docs/readme.linux:INSTALL: Por favor, léelo.
$ find -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o
-iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o
-iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname
_sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o
-iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname
'~.nib' -o -iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o
-iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o
-iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o
-iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname
'*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname
'*.css.min' \) -exec spellintian --picky {} +
./docs/readme.linux: dependant -> dependent
./debian/copyright: debian -> Debian
./debian/capitan.6: spanish -> Spanish
$ suspicious-source
./data/map.dat
./data/sprites.dat
./data/fonts.dat
./data/loading.dat
./data/capitan.at1
./data/bitmaps1.dat
./data/music.dat
./data/bitmaps0.dat
./data/screens.dat
./data/capitan.at2
./data/sfx.dat
$ uscan --report-status --no-verbose
uscan warn: In debian/watch no matching files for watch line
http://computeremuzone.com Capitan(.+).(?:zip|tar\.(?:bz2|gz|xz))
--
bye,
pabs
https://wiki.debian.org/PaulWise
Reply to: