Bug#810012: RFS: averell/1.2.4-1 ITP 773793
Hi,
Thanks for your review.
Le mercredi 06 avril 2016 à 13:23 +0000, Gianfranco Costamagna a
écrit :
> control: tags -1 moreinfo
>
> Hi, lets do another try
>
> 1) please remove the changelog entries.
> "averell (1.0a-1) unstable; urgency=low" <-- this one too
Done
>
> 2)
> override_dh_auto_test
I've re-enabled unit and functional tests, but still disable 'make
check' ie static code analysis which fails for really non critical
issues (not even warnings at compile time).
> override_dh_auto_install:
>
There is only one binary which is installed with 'dh_install'
Upstream's 'make install' installs the binary in '/usr/local/bin'
>
> why?
>
>
> 3) copyright:
> ISC license missing
> grep copyright . -Ri
>
> many people missing
Missing authors are from 'erlang.mk' which is the external build
system. I suppose nobody would include autotools authors, for instance,
even if m4 macros, or generated configure is included in the package,
isn't it ?
>
>
> automatic checks:
> codespell --quiet-level=3
Fixed for CHANGES.md
For erlang.mk, it is external build tool.
>
> grep -Er '/(home|srv|opt)(\W|$)' .
Hard-coded paths are only in unit tests, for testing path
transformation functions.
>
> find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \)
> -exec shellcheck {} +
Fixed
>
> Please add some upstream metadata:
> https://wiki.debian.org/UpstreamMetadata
Done
>
>
> the other stuff LGTM, but I didn't check lintian and build&run yet.
>
> cheers,
>
> G.
>
Would be glad you have a look at freshly uploaded package:
http://mentors.debian.net/package/averell
Cheers,
Jean
Reply to: