[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#819681: RFS: python-django-gravatar2/1.4.0-1 [ITP]

Hi Pierre-Elliott,

On 7 April 2016 at 07:03, Pierre-Elliott Bécue <becue@crans.org> wrote:
> Dear mentors,
> So far it appears that I got no reply. I'm trying a small bump in hope that
> somebody will get interested because of my motivation, or that somebody that
> missed my first mail will see this one! :)

I can't sponsor your package as I have no upload rights, but reviewed it:

* Standards-Version: we are on 3.9.8 since yesterday;
* Vcs-Git: there's no need for "-b master", as this is the default
branch anyway;
* ${shlibs:Depends} can be dropped from the "Depends:" field of each
binary package, as this isn't need for Python packages;
* Architecture: "all" instead of "any" on each binary package.

* Copyright for Tristan Waddington is 2011-2015;
* Copyright for Pierre-Elliott Bécue is 2016;
* Why did you choose GPL-2+ for the packaging work? As said here
before[1], this can be a problem, as this license is more restrictive
than the upstream work, which is MIT.

* Please clean up the file a little, removing (most of) the commented lines;
* Add "export PYBUILD_NAME=django-gravatar2"[2]. That's the reason why
you probably ended up with empty binary packages and needed to add
custom "*.install" files.

python3-django-gravatar2.docs and python-django-gravatar2.docs:
* The preferred format for additional documentation is HTML (Debian
Policy Manual, § 12.4). If you want to ship the contents of the
"README.rst" file you probably want to do this after converting them
to HTML (e.g. using Sphinx).

python3-django-gravatar2.install and python-django-gravatar2.install:
* Unneeded files that should be removed.

Additional suggestions:

* Please create a "debian/source/options"[3] file with
'extend-diff-ignore="^[^/]+\.egg-info/"'. Otherwise you can't build
the package more than one time because dpkg-source will complain about
modified files.
* Is there a reason why you packaged the tarball from PyPI and not a
tarball from the upstream repository[4]? I'm asking this because
there's an override for "override_dh_auto_test" (avoiding it), when
the upstream repository contains tests that would be nice to bring to
the Debian package as well.

I hope this helps you to find a sponsor.


[1]: https://lists.debian.org/debian-mentors/2016/03/msg00332.html
[2]: https://wiki.debian.org/Python/Pybuild#debian.2Frules
[3]: https://wiki.debian.org/Python/FAQ#How_should_we_package_Python_eggs.3F
[4]: https://github.com/twaddington/django-gravatar/releases

Tiago "Myhro" Ilieve
Blog: https://blog.myhro.info/
GitHub: https://github.com/myhro
LinkedIn: https://br.linkedin.com/in/myhro
Montes Claros - MG, Brasil

Reply to: